Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation picker no result and new record improvements #8455

Closed
Bonapara opened this issue Nov 11, 2024 · 11 comments · Fixed by #8485 · May be fixed by #8488
Closed

Relation picker no result and new record improvements #8455

Bonapara opened this issue Nov 11, 2024 · 11 comments · Fixed by #8485 · May be fixed by #8488
Assignees

Comments

@Bonapara
Copy link
Member

Current Behavior

f9dc8a8a45d268784f6b0efcff5e0d501d58a6782ee53636d2ec22368a5caefa

  1. We display an unnecessarily prominent "No result" message.
  2. It's unclear which object will have the record created.

Desired Behavior

1 - No Result

Hide the "No result" message when the search or input yields no results.

2a - When Nothing is Typed in the Search

Display "Create Object-name-singular."

CleanShot 2024-11-11 at 15 04 25

2b - When Something is Typed in the Search

Display "Create Object-name-singular: Record name."

CleanShot 2024-11-11 at 15 03 28

@khuddite
Copy link
Contributor

I will look into the issue

@Bonapara
Copy link
Member Author

Thanks @khuddite, just assigned you!

@khuddite
Copy link
Contributor

CleanShot.2024-11-12.at.05.54.14.mp4

@Bonapara I've found that when there are no results that match my search, Create new button is there and doesn't seem to work at all. Is it a separate issue?

CleanShot.2024-11-12.at.05.56.04.mp4

Also, when the search input is empty, Create new button doesn't even appear.

If they are not desired behaviors, I think they should be addressed first before this ticket.

@ehconitin
Copy link
Contributor

Yep, nothing happens when clicking the "+ Add new" button.
@Bonapara what's the expected behavior on that click? --- Right drawer sequence similar to notes? but we don't do that for companies do we?

@Bonapara
Copy link
Member Author

@ehconitin that would indeed be the good behavior, but maybe it's too expensive?

Your second point is related to: #8169 @khuddite

Thank you both

@ehconitin
Copy link
Contributor

@Bonapara its definitely expensive, maybe just create a company and not show it in the right drawer?
I don't see any other use case where we would need a company in the right drawer

@ehconitin
Copy link
Contributor

Oh there is already a pr for this one #8353

@Bonapara
Copy link
Member Author

Another use case would be creating a company from the People table. I believe this is the desired behavior, but we can address it later.

@khuddite
Copy link
Contributor

@Bonapara So it sounds like what we wanna address in the scope of this ticket is to remove No result, correct?

@Bonapara
Copy link
Member Author

Yes!

@khuddite
Copy link
Contributor

OK, creating a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants