-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickstrom #25
base: main
Are you sure you want to change the base?
Quickstrom #25
Conversation
elm/README.md
Outdated
--max-trailing-state-changes=1 \ | ||
--trailing-state-change-timeout=500 \ | ||
/spec/Tagger.spec.purs \ | ||
http://localhost:8000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am following these instructions, but running into:
2022-06-13 15:34:33 ERROR Error Unable to connect to WebDriver server
Do you have any idea ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this happens if you don't have the selenium/standalone-chrome
container running.
Scripting the two commands together should prevent this from happening
@gdeest I created a script to run |
@marcosh Doing ! |
@marcosh Unfortunately I am still running into the same issue:
I confirmed that the webdriver container is running (the container ID matches the one started by the script) :
|
Increasing the |
makes sense to use something like https://github.com/Eficode/wait-for. It's kind of strange that |
bin/test/quickstrom
Outdated
|
||
docker run --rm -d \ | ||
--name webdriver \ | ||
--network=host \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to be running in host networking mode instead of -p 4444:4444
?
I think host networking doesn't work on Mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, it allows the second docker container to connect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise I guess we need a docker-compose.yml
and a dedicated network. I just copied these from the quickstrom
documentation
@gdeest I tried to move the script do use |
@gdeest did you have the chance to try the new version? |
This branch add end-to-end acceptance tests using Quickstrom