Edit navbar-nav dropdown-menu appearance on condensed navbars #41080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the expanded navbar with a dropdown menu looks like this:
And the condensed navbar with a dropdown menu looks like this:
The proposed fix would make the condensed dropdown menu always pop out as with the expanded navbar, like so:
Motivation & Context
This is purely a cosmetic change, The intention is to make the navbar look better as the current version does not look so nice.
Type of changes
Checklist
npm run lint
)npm test currently failing with the below signature but I don't believe this is due to my changes as it occurs when I run on an unchanged main branch as well. I will open a new issue about this.
Running vnu-jar validation...
command used: java -jar "C:...my_path...\bootstrap\node_modules\vnu-jar\build\dist\vnu.jar" --asciiquotes --skip-non-html --Werror --filterpattern "Attribute “autocomplete” is only allowed when the input type is.*|Attribute “autocomplete” not allowed on element “button” at this point.|An “aria-disabled” attribute whose value is “true” should not be specified on an “a” element that has an “href” attribute." _site/ js/tests/
Live previews
https://deploy-preview-41080--twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#offcanvas
Related issues
Addresses #41049