Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit navbar-nav dropdown-menu appearance on condensed navbars #41080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antoinevilain001
Copy link

@antoinevilain001 antoinevilain001 commented Dec 6, 2024

Description

Currently the expanded navbar with a dropdown menu looks like this:
image
And the condensed navbar with a dropdown menu looks like this:
image
The proposed fix would make the condensed dropdown menu always pop out as with the expanded navbar, like so:
image

Motivation & Context

This is purely a cosmetic change, The intention is to make the navbar look better as the current version does not look so nice.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

npm test currently failing with the below signature but I don't believe this is due to my changes as it occurs when I run on an unchanged main branch as well. I will open a new issue about this.
Running vnu-jar validation...
command used: java -jar "C:...my_path...\bootstrap\node_modules\vnu-jar\build\dist\vnu.jar" --asciiquotes --skip-non-html --Werror --filterpattern "Attribute “autocomplete” is only allowed when the input type is.*|Attribute “autocomplete” not allowed on element “button” at this point.|An “aria-disabled” attribute whose value is “true” should not be specified on an “a” element that has an “href” attribute." _site/ js/tests/

Live previews

https://deploy-preview-41080--twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#offcanvas

Related issues

Addresses #41049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants