-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Indicate links in foreign language #40767
Docs: Indicate links in foreign language #40767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good catch, @hannahiss
The links often include an English part in parentheses, as in 'Bootstrap 5 日本語リファレンス (Japanese)', with 'Japanese' being an English word. However, I think that your modification would likely enhance pronunciation for screen readers in the end, even though in this case, 'Japanese' would also be pronounced in Japanese.
I'm handing this PR over to @patrickhlauke for a double-check and feedback, as it's about accessibility.
Yes, I thought about it, but while respecting accessibility, common words can be in another language. Fro example, in a French sentence, you can have "smartphone", "business" or "French", without indicating they are English words. I think "Japanese" will be understood by Japanese speakers. Anyway, I am curious to have Patrick's opinion on this 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, why not :)
Description
Add a
lang
attribute to links in another language than EnglishMotivation & Context
For accessibility, we have to indicate the links are in a foreign language (not only the target of the link)
Type of changes
Checklist
npm run lint
)Live previews
Related issues