Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: missing aria-hidden on some decorative SVGs #40756

Merged
merged 68 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
86c97b0
Docs: missing aria-hidden on some decorative SVGs
hannahiss Aug 21, 2024
bc3baf6
Docs: missing aria-hidden on check mark on docs version dropdown in d…
hannahiss Aug 21, 2024
47785e5
Docs: missing aria-hidden on check mark on theme toggler dropdown in …
hannahiss Aug 21, 2024
dd14f57
Docs: missing aria-hidden on position utility example
hannahiss Aug 22, 2024
d86fd32
Docs: missing aria-hidden on features examples
hannahiss Aug 22, 2024
40b5ee6
Docs: missing aria-hidden
hannahiss Aug 22, 2024
f004486
Docs: missing label on link
hannahiss Aug 22, 2024
44f19a8
Build(deps-dev): Bump rollup from 4.20.0 to 4.21.1 (#40775)
dependabot[bot] Aug 27, 2024
4debdf1
Build(deps-dev): Bump @babel/preset-env from 7.25.3 to 7.25.4 (#40773)
dependabot[bot] Aug 27, 2024
cd5b819
Build(deps-dev): Bump hugo-bin from 0.129.1 to 0.130.1 (#40774)
dependabot[bot] Aug 27, 2024
bdd3bfc
npm audit fix
XhmikosR Aug 27, 2024
0c60b2d
Build(deps-dev): Bump stylelint-config-twbs-bootstrap (#40786)
dependabot[bot] Sep 3, 2024
96d99e6
Build(deps-dev): Bump rollup from 4.21.1 to 4.21.2 (#40785)
dependabot[bot] Sep 3, 2024
36f255d
Build(deps-dev): Bump eslint-plugin-import from 2.29.1 to 2.30.0 (#40…
dependabot[bot] Sep 3, 2024
fe30d6f
Build(deps-dev): Bump rtlcss from 4.2.0 to 4.3.0 (#40782)
dependabot[bot] Sep 3, 2024
cf2a08d
Build(deps-dev): Bump @babel/cli from 7.24.8 to 7.25.6 (#40788)
dependabot[bot] Sep 3, 2024
d848e9b
Docs: clarify the title on the 'About > Overview' page (#40762)
louismaximepiton Sep 4, 2024
7edecfa
Build(deps-dev): Bump postcss from 8.4.41 to 8.4.44 (#40784)
dependabot[bot] Sep 4, 2024
3b67c66
Docs: add missing `$enable-css-grid` in 'Customize > Options' (#40797)
hannahiss Sep 9, 2024
3375ade
Remove aria-label from this PR
hannahiss Sep 10, 2024
dddafb9
Rollback unwanted modif
hannahiss Sep 10, 2024
006fcfa
Build(deps-dev): Bump postcss from 8.4.44 to 8.4.45 (#40806)
dependabot[bot] Sep 10, 2024
958a6ce
Fix popover remaining open when toggled after being shown (#40803)
bbonch Sep 12, 2024
705d6d6
Docs: update notice on Safari flexbox gap support in 'Helpers > Stack…
coliff Sep 18, 2024
69cfee7
Add missing aria-hidden to decorative `<svg>` and `aria-label` and `r…
hannahiss Sep 20, 2024
354691b
.
hannahiss Sep 20, 2024
bd52658
Add missing aria-hidden to decorative `<svg>` and `aria-label` and `r…
hannahiss Sep 23, 2024
ff6a14c
rollback
hannahiss Sep 23, 2024
99b527b
rollback
hannahiss Sep 23, 2024
ba35585
Docs: update `min-height` inline style for modal with long content (#…
coliff Sep 24, 2024
fb24361
Add missing svgs
louismaximepiton Oct 15, 2024
bfb9b8b
Build(deps): Bump body-parser in the npm_and_yarn group (#40862)
dependabot[bot] Oct 1, 2024
925119a
Build(deps-dev): Bump rollup in the npm_and_yarn group (#40886)
dependabot[bot] Oct 1, 2024
e0b937c
Build(deps-dev): Bump eslint from 8.57.0 to 8.57.1 (#40843)
dependabot[bot] Oct 1, 2024
c1fb40f
Build(deps-dev): Bump hugo-bin from 0.130.1 to 0.132.0 (#40882)
dependabot[bot] Oct 1, 2024
9ced57e
Build(deps-dev): Bump npm-run-all2 from 6.2.2 to 6.2.3 (#40842)
dependabot[bot] Oct 1, 2024
ed27ce3
Dependabot: switch to grouped updates (#40888)
XhmikosR Oct 1, 2024
6c14139
Build(deps-dev): Bump terser from 5.31.6 to 5.34.1 (#40883)
dependabot[bot] Oct 1, 2024
a80793f
Build(deps-dev): Bump the development-dependencies group across 1 dir…
dependabot[bot] Oct 2, 2024
566d76a
Update devDependencies
XhmikosR Oct 2, 2024
00707f7
Remove unneeded flexbug workaround (#40876)
coliff Oct 2, 2024
cc8f95d
package.json: ignore more deps
XhmikosR Oct 2, 2024
301c64f
Docs: fix `$enable-css-grid` → `$enable-cssgrid` in 'Customize > Opti…
julien-deramond Oct 2, 2024
96553d7
Docs: Indicate links in foreign language in Translations page (#40767)
hannahiss Oct 2, 2024
fdb9157
Docs: Make "Edit in Stackblitz" links explicit in 'Examples' page (#4…
hannahiss Oct 6, 2024
b597ee2
Docs: remove unused class in the homepage (#40900)
MohamadSalman11 Oct 7, 2024
6ded8cf
Docs: drop useless `.justify-content-start` class in homepage (#40914)
julien-deramond Oct 7, 2024
d7c1e4d
Examples: fix Cheatsheet examples horizontal scrolling (#40799)
julien-deramond Oct 8, 2024
17fa427
Docs: precise how to add new `.order-*` classes in 'Layout > Columns'…
julien-deramond Oct 9, 2024
4f01df6
Docs: replace `.grid` by `.d-grid` in 'Utilities > Spacing' gap secti…
louismaximepiton Oct 9, 2024
8ecd6b7
Build(deps-dev): Bump the development-dependencies group across 1 dir…
dependabot[bot] Oct 9, 2024
42f65a1
Build(deps): Bump the npm_and_yarn group with 2 updates (#40929)
dependabot[bot] Oct 9, 2024
ab90f5e
Docs: fix `background-blend-mode` CSS value (#40931)
MohamadSalman11 Oct 10, 2024
eda7447
Docs: fix example hiding element except on medium and large devices i…
julien-deramond Oct 16, 2024
0e1443e
Build(deps-dev): Bump the development-dependencies group across 1 dir…
dependabot[bot] Oct 17, 2024
41bd97e
Docs: add ngx-bootstrap to JavaScript frameworks list (#40932)
julien-deramond Oct 21, 2024
27c568b
Docs: fix transparent navbar in Windows high contrast mode (#40911)
MohamadSalman11 Oct 24, 2024
0512685
Docs: correct example formatting in 'Utilities > API' for linting com…
julien-deramond Oct 24, 2024
846c639
Build(deps-dev): Bump the development-dependencies group across 1 dir…
dependabot[bot] Oct 25, 2024
c324375
Build(deps-dev): Bump the development-dependencies group across 1 dir…
dependabot[bot] Nov 6, 2024
8f8ac5b
Docs: fix `.order` values in the migration guide (#41030)
julien-deramond Nov 13, 2024
0304f82
Fix left alignment of floating labels with `.form-select` size varian…
patrickzzz Nov 14, 2024
2ee70cb
Docs: Fix broken link in dropdowns documentation (#41052)
vprothais Nov 22, 2024
8664ebf
Docs: add warning callout for Yarn Berry for Bootstrap examples compa…
julien-deramond Nov 22, 2024
255f296
Build(deps-dev): Bump the development-dependencies group across 1 dir…
dependabot[bot] Dec 7, 2024
0bac1aa
Update devDependencies and regenerate package-lock.json
XhmikosR Dec 7, 2024
2e1f116
Move aria-label to wrapping links
patrickhlauke Dec 10, 2024
44faa3f
Merge branch 'main' into main-his-missing-aria-hidden
patrickhlauke Dec 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/content/docs/5.3/components/tooltips.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ And with custom HTML added:
With an SVG:

<div class="bd-example tooltip-demo">
<a href="#" class="d-inline-block" data-bs-toggle="tooltip" data-bs-title="Default tooltip">
<svg xmlns="http://www.w3.org/2000/svg" width="50" height="50" viewBox="0 0 100 100">
<a href="#" class="d-inline-block" data-bs-toggle="tooltip" data-bs-title="Default tooltip" aria-label="Hover or focus to see default tooltip">
julien-deramond marked this conversation as resolved.
Show resolved Hide resolved
<svg xmlns="http://www.w3.org/2000/svg" width="50" height="50" viewBox="0 0 100 100" aria-hidden="true">
<rect width="100%" height="100%" fill="#563d7c"/>
<circle cx="50" cy="50" r="30" fill="#007bff"/>
</svg>
Expand Down
44 changes: 22 additions & 22 deletions site/content/docs/5.3/examples/features/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -66,35 +66,35 @@ <h2 class="pb-2 border-bottom">Columns with icons</h2>
<div class="row g-4 py-5 row-cols-1 row-cols-lg-3">
<div class="feature col">
<div class="feature-icon d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-2 mb-3">
<svg class="bi" width="1em" height="1em"><use xlink:href="#collection"/></svg>
<svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#collection"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that aria-hidden="true" is unnecessary if the svg doesn't contain any text elements. SRs will ignore them the same way they ignore a series of purely empty presentational <div>s and <span>s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just as a heads-up before you laboriously go and add it to every, single, svg)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your answer :-) Our accessibility experts asked us to add aria-hidden on decorative SVGs in our Boosted doc, so I did it on Bootstrap when relevant. There aren't so much in the doc, but a lot more in the examples...! So if you're ok with this I can stop there and submit the PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder what the rationale provided by the accessibility experts there was.

personally, I have no problem with having all the aria-hiddens added, it just felt a bit wasteful/pointless. but if we're going to add them, then I'd say it should cover all instances, as it would be more confusing if we had a mix of "some <svg>s do have it, others don't". so i'd say either remove the ones you did from this PR, or...go through all the rest

</div>
<h3 class="fs-2 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading. We'll add onto it with another sentence and probably just keep going until we run out of words.</p>
<a href="#" class="icon-link">
Call to action
<svg class="bi"><use xlink:href="#chevron-right"/></svg>
<svg class="bi"><use xlink:href="#chevron-right" aria-hidden="true"/></svg>
</a>
</div>
<div class="feature col">
<div class="feature-icon d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-2 mb-3">
<svg class="bi" width="1em" height="1em"><use xlink:href="#people-circle"/></svg>
<svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#people-circle"/></svg>
</div>
<h3 class="fs-2 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading. We'll add onto it with another sentence and probably just keep going until we run out of words.</p>
<a href="#" class="icon-link">
Call to action
<svg class="bi"><use xlink:href="#chevron-right"/></svg>
<svg class="bi" aria-hidden="true"><use xlink:href="#chevron-right"/></svg>
</a>
</div>
<div class="feature col">
<div class="feature-icon d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-2 mb-3">
<svg class="bi" width="1em" height="1em"><use xlink:href="#toggles2"/></svg>
<svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#toggles2"/></svg>
</div>
<h3 class="fs-2 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading. We'll add onto it with another sentence and probably just keep going until we run out of words.</p>
<a href="#" class="icon-link">
Call to action
<svg class="bi"><use xlink:href="#chevron-right"/></svg>
<svg class="bi" aria-hidden="true"><use xlink:href="#chevron-right"/></svg>
</a>
</div>
</div>
Expand All @@ -107,7 +107,7 @@ <h2 class="pb-2 border-bottom">Hanging icons</h2>
<div class="row g-4 py-5 row-cols-1 row-cols-lg-3">
<div class="col d-flex align-items-start">
<div class="icon-square text-body-emphasis bg-body-secondary d-inline-flex align-items-center justify-content-center fs-4 flex-shrink-0 me-3">
<svg class="bi" width="1em" height="1em"><use xlink:href="#toggles2"/></svg>
<svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#toggles2"/></svg>
</div>
<div>
<h3 class="fs-2 text-body-emphasis">Featured title</h3>
Expand All @@ -119,7 +119,7 @@ <h3 class="fs-2 text-body-emphasis">Featured title</h3>
</div>
<div class="col d-flex align-items-start">
<div class="icon-square text-body-emphasis bg-body-secondary d-inline-flex align-items-center justify-content-center fs-4 flex-shrink-0 me-3">
<svg class="bi" width="1em" height="1em"><use xlink:href="#cpu-fill"/></svg>
<svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#cpu-fill"/></svg>
</div>
<div>
<h3 class="fs-2 text-body-emphasis">Featured title</h3>
Expand All @@ -131,7 +131,7 @@ <h3 class="fs-2 text-body-emphasis">Featured title</h3>
</div>
<div class="col d-flex align-items-start">
<div class="icon-square text-body-emphasis bg-body-secondary d-inline-flex align-items-center justify-content-center fs-4 flex-shrink-0 me-3">
<svg class="bi" width="1em" height="1em"><use xlink:href="#tools"/></svg>
<svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#tools"/></svg>
</div>
<div>
<h3 class="fs-2 text-body-emphasis">Featured title</h3>
Expand Down Expand Up @@ -163,7 +163,7 @@ <h3 class="pt-5 mt-5 mb-4 display-6 lh-1 fw-bold">Short title, long jacket</h3>
<small>Earth</small>
</li>
<li class="d-flex align-items-center">
<svg class="bi me-2" width="1em" height="1em"><use xlink:href="#calendar3"/></svg>
<svg class="bi me-2" width="1em" height="1em" aria-hidden="true"><use xlink:href="#calendar3"/></svg>
<small>3d</small>
</li>
</ul>
Expand Down Expand Up @@ -222,56 +222,56 @@ <h2 class="pb-2 border-bottom">Icon grid</h2>

<div class="row row-cols-1 row-cols-sm-2 row-cols-md-3 row-cols-lg-4 g-4 py-5">
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#bootstrap"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#bootstrap"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#cpu-fill"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#cpu-fill"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#calendar3"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#calendar3"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#home"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#home"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#speedometer2"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#speedometer2"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#toggles2"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#toggles2"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#geo-fill"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#geo-fill"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
</div>
</div>
<div class="col d-flex align-items-start">
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#tools"/></svg>
<svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#tools"/></svg>
<div>
<h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3>
<p>Paragraph of text beneath the heading to explain the heading.</p>
Expand All @@ -296,7 +296,7 @@ <h2 class="fw-bold text-body-emphasis">Left-aligned title explaining these aweso
<div class="row row-cols-1 row-cols-sm-2 g-4">
<div class="col d-flex flex-column gap-2">
<div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3">
<svg class="bi" width="1em" height="1em">
<svg class="bi" width="1em" height="1em" aria-hidden="true">
<use xlink:href="#collection" />
</svg>
</div>
Expand All @@ -306,7 +306,7 @@ <h4 class="fw-semibold mb-0 text-body-emphasis">Featured title</h4>

<div class="col d-flex flex-column gap-2">
<div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3">
<svg class="bi" width="1em" height="1em">
<svg class="bi" width="1em" height="1em" aria-hidden="true">
<use xlink:href="#gear-fill" />
</svg>
</div>
Expand All @@ -316,7 +316,7 @@ <h4 class="fw-semibold mb-0 text-body-emphasis">Featured title</h4>

<div class="col d-flex flex-column gap-2">
<div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3">
<svg class="bi" width="1em" height="1em">
<svg class="bi" width="1em" height="1em" aria-hidden="true">
<use xlink:href="#speedometer" />
</svg>
</div>
Expand All @@ -326,7 +326,7 @@ <h4 class="fw-semibold mb-0 text-body-emphasis">Featured title</h4>

<div class="col d-flex flex-column gap-2">
<div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3">
<svg class="bi" width="1em" height="1em">
<svg class="bi" width="1em" height="1em" aria-hidden="true">
<use xlink:href="#table" />
</svg>
</div>
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/5.3/utilities/position.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Here are some real life examples of these classes:
</button>

<div class="position-relative py-2 px-4 text-bg-secondary border border-secondary rounded-pill">
Marker <svg width="1em" height="1em" viewBox="0 0 16 16" class="position-absolute top-100 start-50 translate-middle mt-1" fill="var(--bs-secondary)" xmlns="http://www.w3.org/2000/svg"><path d="M7.247 11.14L2.451 5.658C1.885 5.013 2.345 4 3.204 4h9.592a1 1 0 0 1 .753 1.659l-4.796 5.48a1 1 0 0 1-1.506 0z"/></svg>
Marker <svg width="1em" height="1em" viewBox="0 0 16 16" class="position-absolute top-100 start-50 translate-middle mt-1" fill="var(--bs-secondary)" xmlns="http://www.w3.org/2000/svg" aria-hidden="true"><path d="M7.247 11.14L2.451 5.658C1.885 5.013 2.345 4 3.204 4h9.592a1 1 0 0 1 .753 1.659l-4.796 5.48a1 1 0 0 1-1.506 0z"/></svg>
</div>

<button type="button" class="btn btn-primary position-relative">
Expand Down
2 changes: 1 addition & 1 deletion site/layouts/partials/docs-versions.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<li>
<a class="dropdown-item d-flex align-items-center justify-content-between active" aria-current="true" href="{{ if .IsHome }}/{{ else }}/docs/{{ .Site.Params.docs_version }}/{{ $versions_link }}{{ end }}">
Latest ({{ .Site.Params.docs_version }}.x)
<svg class="bi"><use xlink:href="#check2"></use></svg>
<svg class="bi" aria-hidden="true"><use xlink:href="#check2"></use></svg>
</a>
</li>
<li>
Expand Down
2 changes: 1 addition & 1 deletion site/layouts/partials/icons/hamburger.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 7 additions & 7 deletions site/layouts/partials/theme-toggler.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,29 @@
data-bs-toggle="dropdown"
{{ if not $isExamples }}data-bs-display="static"{{ end }}
aria-label="Toggle theme (auto)">
<svg class="bi my-1 theme-icon-active"><use href="#circle-half"></use></svg>
<svg class="bi my-1 theme-icon-active" aria-hidden="true"><use href="#circle-half"></use></svg>
<span class="{{ if $isExamples }}visually-hidden{{ else }}d-lg-none ms-2{{ end }}" id="bd-theme-text">Toggle theme</span>
</button>
<ul class="dropdown-menu dropdown-menu-end{{ if $isExamples }} shadow{{ end }}" aria-labelledby="bd-theme-text">
<li>
<button type="button" class="dropdown-item d-flex align-items-center" data-bs-theme-value="light" aria-pressed="false">
<svg class="bi me-2 opacity-50"><use href="#sun-fill"></use></svg>
<svg class="bi me-2 opacity-50" aria-hidden="true"><use href="#sun-fill"></use></svg>
Light
<svg class="bi ms-auto d-none"><use href="#check2"></use></svg>
<svg class="bi ms-auto d-none" aria-hidden="true"><use href="#check2"></use></svg>
</button>
</li>
<li>
<button type="button" class="dropdown-item d-flex align-items-center" data-bs-theme-value="dark" aria-pressed="false">
<svg class="bi me-2 opacity-50"><use href="#moon-stars-fill"></use></svg>
<svg class="bi me-2 opacity-50" aria-hidden="true"><use href="#moon-stars-fill"></use></svg>
Dark
<svg class="bi ms-auto d-none"><use href="#check2"></use></svg>
<svg class="bi ms-auto d-none" aria-hidden="true"><use href="#check2"></use></svg>
</button>
</li>
<li>
<button type="button" class="dropdown-item d-flex align-items-center active" data-bs-theme-value="auto" aria-pressed="true">
<svg class="bi me-2 opacity-50"><use href="#circle-half"></use></svg>
<svg class="bi me-2 opacity-50" aria-hidden="true"><use href="#circle-half"></use></svg>
Auto
<svg class="bi ms-auto d-none"><use href="#check2"></use></svg>
<svg class="bi ms-auto d-none" aria-hidden="true"><use href="#check2"></use></svg>
</button>
</li>
</ul>
Loading