Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: missing aria-hidden on some decorative SVGs #40756
Docs: missing aria-hidden on some decorative SVGs #40756
Changes from 7 commits
86c97b0
bc3baf6
47785e5
dd14f57
d86fd32
40b5ee6
f004486
44f19a8
4debdf1
cd5b819
bdd3bfc
0c60b2d
96d99e6
36f255d
fe30d6f
cf2a08d
d848e9b
7edecfa
3b67c66
3375ade
dddafb9
006fcfa
958a6ce
705d6d6
69cfee7
354691b
bd52658
ff6a14c
99b527b
ba35585
fb24361
bfb9b8b
925119a
e0b937c
c1fb40f
9ced57e
ed27ce3
6c14139
a80793f
566d76a
00707f7
cc8f95d
301c64f
96553d7
fdb9157
b597ee2
6ded8cf
d7c1e4d
17fa427
4f01df6
8ecd6b7
42f65a1
ab90f5e
eda7447
0e1443e
41bd97e
27c568b
0512685
846c639
c324375
8f8ac5b
0304f82
2ee70cb
8664ebf
255f296
0bac1aa
2e1f116
44faa3f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that
aria-hidden="true"
is unnecessary if the svg doesn't contain any text elements. SRs will ignore them the same way they ignore a series of purely empty presentational<div>
s and<span>
sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just as a heads-up before you laboriously go and add it to every, single, svg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your answer :-) Our accessibility experts asked us to add aria-hidden on decorative SVGs in our Boosted doc, so I did it on Bootstrap when relevant. There aren't so much in the doc, but a lot more in the examples...! So if you're ok with this I can stop there and submit the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder what the rationale provided by the accessibility experts there was.
personally, I have no problem with having all the
aria-hidden
s added, it just felt a bit wasteful/pointless. but if we're going to add them, then I'd say it should cover all instances, as it would be more confusing if we had a mix of "some<svg>
s do have it, others don't". so i'd say either remove the ones you did from this PR, or...go through all the rest