Add new test cases for the SmoothScroll of the scrollspy spec
#40653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
XhmikosR
changed the title
SmoothScroll of the scrollspy spec
- Added StackedNotificationManager class to handle creation, management, and dismissal of stacked notifications. - Notifications are displayed in a stack format with the newest at the top. - Added automatic dismissal feature with customizable timeouts. - Added manual dismissal option via a close button. - Included functionality to clear all active notifications at once.
|
Hey there, can you revert 184f4c7 and make it a different PR if needed (see #40731 (comment)), so it would be easier for us to review. |
…smissal" This reverts commit 184f4c7.
Hey there. I followed your instructions and revert it 184f4c7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CT1: should enable smoothScroll and support scroll if ScrollSpy is enabled and the section is visible
This test initializes the ScrollSpy with smooth scrolling enabled and verifies that the EventHandler.off and EventHandler.on methods are called with the expected arguments when the section is visible.
CT2: should disable smoothScroll and support scroll if ScrollSpy is disabled and the section is visible
This test initializes the ScrollSpy with smooth scrolling disabled and checks if the EventHandler.off method is called and EventHandler.on is not called, even when the section is visible.
CT3: should not smoothScroll if the section is not visible, even if ScrollSpy is enabled
This test ensures that smooth scrolling does not occur when the section is not visible, despite ScrollSpy being enabled. It verifies that the scroll action is not triggered for a hidden section.
CT4: should not smoothScroll if the section is not visible and smoothScroll is disabled
This test checks that smooth scrolling does not occur when both the section is not visible and smooth scrolling is disabled. It ensures that the scroll action is not triggered for a hidden section with smooth scrolling turned off.
Motivation & Context
The new tests improve the coverage of the Statements (97,54% to 97,59%), Branches (91,59% to 91,73%) and Lines (97,53% to 91,58%)
Type of changes
Checklist
npm run lint)