Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: minor tweaks #39724

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Docs: minor tweaks #39724

merged 3 commits into from
Mar 6, 2024

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 3, 2024 •
edited
Loading

@XhmikosR XhmikosR marked this pull request as ready for review March 3, 2024 06:16
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch from acae61b to a15cb1f Compare March 3, 2024 06:22
@XhmikosR XhmikosR marked this pull request as draft March 3, 2024 16:17
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch 3 times, most recently from 1111e19 to 5a871e9 Compare March 3, 2024 16:45
@XhmikosR XhmikosR marked this pull request as ready for review March 3, 2024 16:48
@XhmikosR XhmikosR requested a review from a team as a code owner March 3, 2024 16:48
@XhmikosR XhmikosR requested a review from mdo March 3, 2024 16:48
julien-deramond
julien-deramond approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catches and nice technical evolutions!
FYI I've moved the PR to the GH project v5.3.4 instead of v5.4.0.

site/layouts/shortcodes/deprecated-in.html Outdated Show resolved Hide resolved
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch 2 times, most recently from c23d4c7 to a0a79c0 Compare March 4, 2024 10:51
@XhmikosR XhmikosR marked this pull request as draft March 4, 2024 18:48
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 4, 2024

I converted this to draft, I want to fix more redirects and 404s tomorrow. I'll probably split this into smaller PRs after I'm done.

@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch 11 times, most recently from 2e19e35 to 61f53bc Compare March 5, 2024 13:38
@XhmikosR XhmikosR mentioned this pull request Mar 5, 2024
Merged
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch 2 times, most recently from 03acd2d to d0035c4 Compare March 5, 2024 14:46
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch 3 times, most recently from f97c930 to b160922 Compare March 5, 2024 18:29
@XhmikosR XhmikosR mentioned this pull request Mar 5, 2024
Merged
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch from b160922 to 26b4636 Compare March 5, 2024 18:58
@XhmikosR XhmikosR mentioned this pull request Mar 6, 2024
Merged
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch from e82e851 to 1828f36 Compare March 6, 2024 07:54
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch from 1828f36 to ca59347 Compare March 6, 2024 08:21
@XhmikosR XhmikosR changed the title Docs: minor template tweaks Docs: minor tweaks Mar 6, 2024
XhmikosR added 2 commits March 6, 2024 13:42
@XhmikosR
Update hugo server options
8ea9982 
Add --noHTTPCache --renderToMemory --printPathWarnings
@XhmikosR
docsref.html: move to variable
42b0676
@XhmikosR XhmikosR force-pushed the xmr/docs-render-heading branch from ca59347 to 42b0676 Compare March 6, 2024 11:42
@XhmikosR XhmikosR marked this pull request as ready for review March 6, 2024 11:43
@XhmikosR XhmikosR merged commit b003fc7 into main Mar 6, 2024
14 checks passed
@XhmikosR XhmikosR deleted the xmr/docs-render-heading branch March 6, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
docs no squash
Projects
v5.3.4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @julien-deramond