Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .bg-{color}-subtle work with .bg-opacity-{value} #39235

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 25, 2023

Description

⚠️ This is a draft PR to evaluate what impact such an enhancement could have.

  • ⚠️ Before merging, modifications in the album example should be removed.

  • Finalize the development part
  • Documentation modifications?
  • Migration guide?

Impact: this is not a breaking change per se, but there is still a little change in some supported behaviors, so the target version would be 5.4 for safety.

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38924

@julien-deramond julien-deramond force-pushed the main-jd-make-suble-bg-utilities-work-with-bg-opacity-utilities branch 2 times, most recently from f03e59f to 360bc9d Compare September 25, 2023 10:51
@julien-deramond julien-deramond force-pushed the main-jd-make-suble-bg-utilities-work-with-bg-opacity-utilities branch from 6faf0f7 to 3c0d873 Compare October 17, 2023 07:12
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, let's do it. To be safe, let's save it for v5.4.0 maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

-subtle color background utility classes don't support opacity
2 participants