Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color mode: Offer an alternative data-bs-theme="body" #39188

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Sep 15, 2023

Description

⚠️ Make sure the example is removed before merge.

Add a special "theme" that only replicate the main theme of the page.

❓ If this theme is accepted, we might introduce data-bs-theme="inverted" that inverts the global theme. Here is an example of how it could be implemented atm: https://codepen.io/louismaximepiton/pen/vYbEvLO.

Motivation & Context

Get rid of dark variants.
Quality of life for end-users.
New feature that adds functionality to help people find a way to have the previous behavior (v5.2.3) (without JS)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

On this test page that has to be removed, the rendering of every kind of use of navbar and its associated dropdown.

Related issues

Closes #38973.

@louismaximepiton louismaximepiton marked this pull request as ready for review September 15, 2023 13:50
@louismaximepiton louismaximepiton requested a review from a team as a code owner September 15, 2023 13:50
@louismaximepiton louismaximepiton requested a review from a team as a code owner October 5, 2023 12:45
@louismaximepiton louismaximepiton force-pushed the main-lmp-dark-mode-example-context branch from 15184f5 to 183862c Compare October 5, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-bs-theme="dark" behaves differently compared to CSS class navbar-dark
1 participant