-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guard rail to dropdown keyhandler #37755
base: main
Are you sure you want to change the base?
Conversation
As much as I want to protect us of future misleading issues related to docs examples, I would never prefer to add this dummy "silencer" as it will affect the real implementations' strictness and feedback. And for sure, a dropdown without a toggler, has wrong markup 😞 Maybe is a better, just add a note on dropdown examples |
x-ref #34349 |
e91f966
to
cedd335
Compare
any decision/thoughts on this? |
@GeoSot @julien-deramond so what do we want to do here? I think the options are to:
|
Description
Adds a guard rail/sanity check to the keyboard handler, to bail out if there's no actual toggle button
Motivation & Context
While good practice in general (as it does not assume there is a toggle button), this also prevents the type error in our documentation where we have examples of dropdown menus that are "static" and already opened.
Type of changes
Checklist
npm run lint
)Live previews
https://deploy-preview-37755--twbs-bootstrap.netlify.app/docs/5.3/components/dropdowns/#active
Related issues
Closes #37428