fix(agent): share extension adapters across workspace agents - #2520
Draft
7155 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: undo <2333620@tongji.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extension installation instead of the logical
workspace-agent:*IDpreserving their independent Agent identities
Extension installation changes
trusted provider binding
Before this change, the first Workspace Agent using an Extension permanently
bound the provider-scoped adapter cache to its logical Agent ID. A second
Workspace Agent using the same trusted Harness then failed with
cached adapter binding mismatchuntil the daemon restarted.Reproduction
installed Agent Extension, such as Hermes Agent.
main, Agent B fails withcached adapter binding mismatch for "acp:hermes". Reversing the order afteranother restart makes B work and A fail instead.
Verification
upstream/main@6d4778dc4:TestRuntimeAdapterBindingAllowsWorkspaceAgentsToShareTrustedHarnessgo test ./service/agentextension -run '^TestRuntimeAdapterBindingAllowsWorkspaceAgentsToShareTrustedHarness$' -count=1go test ./runtime -run '^(TestOpenStandardACPAdapterCacheFailsClosedAcrossTargetBindings|TestControllerCanResumeAuthorizedAgentExtensionBinding)$' -count=1pnpm check:changed -- --base upstream/main --push-ready(10 lanes passed)Agent B used the same Hermes Agent Extension and both completed real provider
requests; before the fix, Agent B failed with the cache binding mismatch
Checklist
provider adapter binding used by an existing create/resume flow.
supported Workspace Agent/Extension behavior without changing setup or a
public contract.