fix(agent-replay): preserve guest path compatibility on Windows - #2406
Open
hugozhou-ai wants to merge 1 commit into
Open
fix(agent-replay): preserve guest path compatibility on Windows#2406hugozhou-ai wants to merge 1 commit into
hugozhou-ai wants to merge 1 commit into
Conversation
Signed-off-by: HugoZhou <hugozhou0638@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn/start.cwdfield only when it equals the declared default replay CWDWhy
Native Windows TSH replay runs execute the provider inside a Linux HCS guest. Host
filepathsemantics rejected or rewrote guest paths, while older Cassettes omitted the default Codexturn/start.cwdfield now emitted by newer providers.Risk
The compatibility rule is descriptor-owned and narrow: it applies only to declared methods, only when the recorded field is absent, and only when the live value exactly equals the replay CWD. Non-default CWD mismatches continue to fail closed.
Verification
go test ./...inpackages/agent/session-replaygo test ./packages/agent/daemon/runtime -run 'TestReplayProcessTransport(AcceptsDefaultCWDAddedByNewerProvider|MapsRecordedCWDInStrictJSONMatch|FailsClosedOnOutboundMismatch)$' -count=1C01_TURN_3_COMPLETEDgit diff --check origin/main...HEADWindows impact
Covered by cross-platform absolute-path tests, logical POSIX replay-root tests, and the real native HCS/VMP replay runs above.
Documentation impact
No durable documentation change is required. The existing Session Replay README already defines
${REPLAY_CWD}as the portable guest-path boundary; this change makes Windows implementation match that contract.