Enhance trade summary and payment details

Refined the trade summary output to only include a footer if the trade involves mortgaged properties. Additionally, changes ensure that payment details are only added to the bill of materials when the player has a positive balance. This eliminates unnecessary information and clarifies the transaction summary provided to players.

DiscordMonies/Game/GameControllerService.cs

@@ -928,8 +928,12 @@ public async Task DropPlayer(GamePlayer player)
         List<string> billOfMaterials = [];
 
         // Use TryPay because Pay will queue up a payment
+        if (player.Money > 0)
+        {
+            billOfMaterials.Add($"{player.Money.MoneyString()} {Emoji.ArrowRight} **{transferredName}**");
+        }
+
         await TryPay(player, transferredAssets, player.Money, true);
-        billOfMaterials.Add($"{player.Money.MoneyString()} {Emoji.ArrowRight} **{transferredName}**");
 
         List<IOwnable> playerAssets = [];
         playerAssets.AddRange(state.Board.Spaces.Where(space => space.Owner == player));

DiscordMonies/Game/Trade/TradeTable.cs

@@ -45,12 +45,18 @@ public TradeTable Copy()
 
     public Embed PrintTradeTable(bool asGiving)
     {
-        return new EmbedBuilder()
+        var builder = new EmbedBuilder()
             .WithTitle("Trade")
             .AddField($"{From} gives", string.Join("\n", Giving.Select(OwnableEntry).Append(Money > 0 ? Money.MoneyString() : string.Empty))).Get()
-            .AddField($"{To} gives", string.Join("\n", Receiving.Select(OwnableEntry).Append(Money < 0 ? (-Money).MoneyString() : string.Empty))).Get()
-            .WithFooter($"{Emoji.CircledM} indicates mortgaged properties, which if traded, will need to be immediately unmortgaged or a 10% mortgage transfer fee paid to the bank.")
-            .Build().Get();
+            .AddField($"{To} gives", string.Join("\n", Receiving.Select(OwnableEntry).Append(Money < 0 ? (-Money).MoneyString() : string.Empty))).Get();
+
+        if (Giving.Concat(Receiving).Any(x => x is Space { IsMortgaged: true }))
+        {
+            builder = builder.WithFooter(
+                $"{Emoji.CircledM} indicates mortgaged properties, which if traded, will need to be immediately unmortgaged or a 10% mortgage transfer fee paid to the bank by the recipient.");
+        }
+
+        return builder.Build().Get();
     }
 
     private static string OwnableEntry(IOwnable ownable)