Support pragma foreign_keys in batch()
#174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarna
reviewed
Feb 1, 2024
| @@ -227,12 +227,28 @@ export abstract class HranaTransaction implements Transaction { | |||
| } | |||
| } | |||
|
|
|||
| export function isHranaPragmaStmt(stmt: hrana.Stmt): boolean { | |||
| if (typeof stmt.sql === "string") { | |||
| return stmt.sql.toUpperCase().startsWith("PRAGMA "); | |||
There was a problem hiding this comment.
that's too eager - pragma foreign_keys is explicitly documented to not work in transaction context, but there are lots of pragmas that do, and sometimes you may need them to be atomic. Think pragmas that check if the schema is in some particular shape
|
Applications should use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.