cli: Fix overlay mount I/O error by unifying whiteout schema in SDK #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whiteout table created by `agentfs init --base` was missing the `parent_path` column that `overlayfs.rs` queries during directory listing. This caused `get_child_whiteouts()` to fail with a SQL error, which propagated as an I/O error when running `ls` on the mounted filesystem. The fix moves the schema definition to a single location in the SDK (`OverlayFS::init_schema`) to prevent future drift between CLI and SDK. The CLI now calls this method instead of duplicating the SQL. Also removes dead `base_type` code that was set but never read. Fixes #106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whiteout table created by
agentfs init --basewas missing theparent_pathcolumn thatoverlayfs.rsqueries during directory listing. This causedget_child_whiteouts()to fail with a SQL error, which propagated as an I/O error when runninglson the mounted filesystem.The fix moves the schema definition to a single location in the SDK (
OverlayFS::init_schema) to prevent future drift between CLI and SDK. The CLI now calls this method instead of duplicating the SQL.Also removes dead
base_typecode that was set but never read.Fixes #106