sdk/rust: Fix resolve to prioritize agent ID over file path #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, AgentFSOptions::resolve() checked if a path exists before
checking .agentfs/{id}.db. This caused issues when a directory existed
with the same name as an agent - the directory would be selected and
fail with "I/O error: is a directory".
Now the resolution order is:
1. :memory: -> ephemeral
2. Valid agent ID with existing .agentfs/{id}.db -> use agent
3. Existing file path -> use direct path
This ensures agents in .agentfs/ always take precedence over
files/directories in the current directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AgentFSOptions::resolve() checked if a path exists before checking .agentfs/{id}.db. This caused issues when a directory existed with the same name as an agent - the directory would be selected and fail with "I/O error: is a directory".
Now the resolution order is:
This ensures agents in .agentfs/ always take precedence over files/directories in the current directory.