get rid of docker-compose shell out #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -63,6 +63,7 @@ fargate service deploy -r 37 | |||
| return | |||
| } | |||
|
|
|||
| console.Info("here") | |||
There was a problem hiding this comment.
Probably want to take this out :)
| @@ -82,9 +83,10 @@ func init() { | |||
| } | |||
|
|
|||
| func deployService(operation *ServiceDeployOperation) { | |||
| console.Info("Hello?!") | |||
nickpadovani
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on getting rid of the docker-compose shell out and also allowing to pass in multiple docker-compose files so they can be merged which would allow for an inheritance model for fargate deploys. Removing the dependency on docker-compse also allows for easier install. The inclusion of the compose-spec library also would allow the fargate cli to more easily extend that spec.
There is a problem that the compose-spec library only supports v3+, which I didn't realize would be an issue while developing this. They supposedly support v2 but the Load function fails the tests for v2 ( removed in this PR ). compose-spec/compose-spec#12
Didn't know if it would be useful, so just throwing it up any way.