Configure plugin start timeout for go-plugin.Client (#4477) #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmische
commented
Jan 25, 2025
pkg/pluginmanager/lifecycle.go
Outdated
| @@ -64,6 +65,7 @@ func start(steampipeExecutablePath string) (*State, error) { | |||
| Cmd: pluginManagerCmd, | |||
| AllowedProtocols: []plugin.Protocol{plugin.ProtocolGRPC}, | |||
| Logger: logger, | |||
| StartTimeout: 3 * time.Minute, //TODO: macke this configurable | |||
There was a problem hiding this comment.
The timeout for the plugin manager startup needs to be extended to accommodate longer plugin startup. I didn't see an immediate way to make this configurable, so I extended this from 1 minute to 3 minutes for now.
|
Thanks @nmische for the contribution. I will take a look at the changes and submit my review. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4477.
The hashicorp/go-plugin client configuration has a default timeout of 60s. This causes steampipe startup to fail if a plugin takes longer than 60s.
This PR ensures a plugin's client is configured with the timeout settings from the steampipe plugin configuration.
It also extends the plugin manager client start timeout from 1 minute to 3 minutes as testing indicated this timeout setting also governed overall steampipe startup. Ideally this timeout would be set to the maximum plugin timeout setting, however I didn't see any easy way to achieve that so opted to extend the default for now.