-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure plugin start timeout for go-plugin.Client (#4477) #4478
base: develop
Are you sure you want to change the base?
Conversation
pkg/pluginmanager/lifecycle.go
Outdated
@@ -64,6 +65,7 @@ func start(steampipeExecutablePath string) (*State, error) { | |||
Cmd: pluginManagerCmd, | |||
AllowedProtocols: []plugin.Protocol{plugin.ProtocolGRPC}, | |||
Logger: logger, | |||
StartTimeout: 3 * time.Minute, //TODO: macke this configurable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout for the plugin manager startup needs to be extended to accommodate longer plugin startup. I didn't see an immediate way to make this configurable, so I extended this from 1 minute to 3 minutes for now.
Thanks @nmische for the contribution. I will take a look at the changes and submit my review. 👍 |
Bumping this - looks like it's causing me issues. Using the terraform plugin, If I put more than a few s3 paths to state files, especially if there are large files - I get a timeout error:
I set plugin.start_timeout = 600 option in default.spc but it doesn't seem to have any effect I'm hoping that this will fix the issue. |
I have 24 k8s cluster and I get the same error. |
@gkid @ramses999 @nmische |
Unfortunately I can't reproduce the problem, now everything works with the old build. Maybe there was network degradation yesterday and k8s responded slowly. I understand correctly that I should get an error, then set the |
![]() Hi. Either this doesn't work, or I'm doing something wrong. |
@pskrbasu Sorry, I didn't take into account that dpkg puts it in directory In fact, everything works, I suggest that you can merge it into Main ![]() |
Addresses #4477.
The hashicorp/go-plugin client configuration has a default timeout of 60s. This causes steampipe startup to fail if a plugin takes longer than 60s.
This PR ensures a plugin's client is configured with the timeout settings from the steampipe plugin configuration.
It also extends the plugin manager client start timeout from 1 minute to 3 minutes as testing indicated this timeout setting also governed overall steampipe startup. Ideally this timeout would be set to the maximum plugin timeout setting, however I didn't see any easy way to achieve that so opted to extend the default for now.