Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Notification implement #7 #75

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Web Notification implement #7 #75

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96af1b7
add notification sending base
Page-David Jul 7, 2017
b185f3d
add compacity check and string format error
Page-David Jul 7, 2017
d8804f6
True to true..
Page-David Jul 7, 2017
c6c494c
remove alert
huiyiqun Jul 7, 2017
6f441d1
Solve variable conflict
Page-David Jul 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions fishroom/web/chat_log.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,21 @@ <h3><i class="glyphicon glyphicon-refresh"></i> Loading ...</h3>
msg.id = fishLogData.current_id;
fishLogData.current_id++;
fishLogData.msgs.push(msg);
// Notification sending...
var notification = 'New message from ' + msg.sender;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉，突然发现标题名和Notification实例名冲突了。

if ('Notification' in window) {
if (Notification.permission === 'granted') {
var notification = new Notification(notification);
}

else if (Notification.permission !== 'denied') {
Notification.requestPermission(function (permission) {
if (permission === 'granted') {
var notification = new Notification(notification);
}
});
}
}
}

var fetchLog = function(limit, lastId, scrollDown) {
Expand Down