fix: double offset bug in ip address calculation for pseudo headers #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a critical bug in `apply_tcp_coalesce_accounting` and `apply_udp_coalesce_accounting` where the buffer offset was added twice when calculating the source and destination address positions. The packet buffer slice (`pkt`) was already offset by `offset` (i.e. VIRTIO_NET_HDR_LEN), but the code added `offset` again to `addr_offset`. This caused the pseudo-header checksum to be calculated using garbage data (often bytes from the Transport header) instead of the correct Source and Destination IP addresses. This resulted in invalid TCP/UDP checksum seeds, causing dropped packets.
Contributor
Author
|
Any advice on how to deal with the failing checks? They don't seem to be related to my changes |
Collaborator
Let's ignore this problem, I'll handle it. |
Collaborator
|
This issue is caused by an update in libc. You can refer to nix-rust/nix#2709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a critical bug in
apply_tcp_coalesce_accountingandapply_udp_coalesce_accountingwhere the buffer offset was added twice when calculating the source and destination address positions.The packet buffer slice (
pkt) was already offset byoffset(i.e. VIRTIO_NET_HDR_LEN), but the code addedoffsetagain toaddr_offset. This caused the pseudo-header checksum to be calculated using garbage data (often bytes from the Transport header) instead of the correct Source and Destination IP addresses.This resulted in invalid TCP/UDP checksum seeds, causing dropped packets.