-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to CKAN 2.11.0 official Docker image #71
base: main
Are you sure you want to change the base?
feat: Upgrade to CKAN 2.11.0 official Docker image #71
Conversation
ckan config-tool "${CKAN_INI}" "ckan.harvest.log_level = debug" && \ | ||
ckan config-tool "${CKAN_INI}" "ckan.harvest.log_timeframe = 10" && \ | ||
ckan config-tool "${CKAN_INI}" "PERMANENT_SESSION_LIFETIME = 600" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ckan config-tool "${CKAN_INI}" "PERMANENT_SESSION_LIFETIME = 600" && \
ckan config-tool "${CKAN_INI}" "ckanext.security.redis.host = redis" && \
ckan config-tool "${CKAN_INI}" "ckanext.security.redis.port = 6379" && \
ckan config-tool "${CKAN_INI}" "ckanext.security.redis.db = 1"
we should add this settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to avoid hardcoding this. Or is this just defaults, that we can override with env vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The harvest configuration is fully removed from the Dockerfile.
The build currently fails with this:
|
Hey @BWibo thanks for the review, actually the build is failing because of the code in the Dockerfile.debug files, I even changed the FROM image version to 2.11.1 and again we have the some issue. Is it ok for you to comment/remove the build part for the .debug images? The upgrade to 2.11.1 is not dependent on the .debug stages and that part is blocking our progress to making a final release for 2.11.1. |
@ilchebedelovski It's working now, so your comment above is obsolete, right? |
# ############################################################################# | ||
# # Runtime stage | ||
# ############################################################################# | ||
FROM ${BASEIMAGE_REPOSITORY}:${BASEIMAGE_VERSION} as runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sddi
image needs to use our base
image as base.
@MarijaKnezevic Discuss with @aleksandralazoroska @ilchebedelovski which extension go in which Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extensions are solved, part of them are in sddi-base and the rest of them are in sddi according to the documentation in the Readme file.
Yes, now looks good, thanks. |
This PR includes updates to the SDDI base for CKAN 2.11.0 along with the following key changes:
Other todos:
sddi-social
image variant #60