tig · Jul 7, 2026 · Jun 28, 2026 · Jun 29, 2026 · Jul 1, 2026 · Jul 1, 2026
@@ -48,12 +48,12 @@ jobs:
           git config user.email "github-actions[bot]@users.noreply.github.com"
 
       - name: Install GitVersion
-        uses: gittools/actions/gitversion/setup@v4.5.0
+        uses: gittools/actions/gitversion/setup@v4.7.0
         with:
           versionSpec: '6.x'
 
       - name: Determine Version
-        uses: gittools/actions/gitversion/execute@v4.5.0
+        uses: gittools/actions/gitversion/execute@v4.7.0
         with:
           useConfigFile: true
         id: gitversion

@@ -32,12 +32,12 @@ jobs:
     # from git history + GitVersion.yml during build. We still run the CLI here to
     # capture the SemVer for use in subsequent steps (push, template dispatch).
     - name: Install GitVersion
-      uses: gittools/actions/gitversion/setup@v4.5.0
+      uses: gittools/actions/gitversion/setup@v4.7.0
       with:
         versionSpec: '6.x'
 
     - name: Determine Version
-      uses: gittools/actions/gitversion/execute@v4.5.0
+      uses: gittools/actions/gitversion/execute@v4.7.0
       with:
         useConfigFile: true
       id: gitversion # step id used as reference for output values

@@ -8,7 +8,7 @@
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.14.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="4.14.0" />
-    <PackageVersion Include="Microsoft.Net.Compilers.Toolset" Version="5.3.0" />
+    <PackageVersion Include="Microsoft.Net.Compilers.Toolset" Version="5.6.0" />
     <PackageVersion Include="Microsoft.DotNet.PlatformAbstractions" Version="3.1.6" />
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.203" />
     <PackageVersion Include="Microsoft.CodeAnalysis" Version="4.14.0" />
@@ -17,13 +17,13 @@
     <PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.7" />
     <PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.7" />
     <PackageVersion Include="Microsoft.Extensions.Configuration.Json" Version="10.0.7" />
-    <PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.7" />
+    <PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.9" />
     <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.7" />
     <PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.7" />
     <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.7" />
     <PackageVersion Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.23.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.7.0" />
-    <PackageVersion Include="Spectre.Console" Version="0.57.1" />
+    <PackageVersion Include="Spectre.Console" Version="0.57.2" />
     <PackageVersion Include="TestableIO.System.IO.Abstractions.TestingHelpers" Version="22.1.1" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
     <PackageVersion Include="xunit.v3" Version="3.2.2" />
@@ -52,7 +52,7 @@
     <PackageVersion Include="Moq" Version="4.20.72" />
     <PackageVersion Include="ReportGenerator" Version="5.5.9" />
     <PackageVersion Include="coverlet.collector" Version="10.0.0" />
-    <PackageVersion Include="GitVersion.MsBuild" Version="6.7.0" />
+    <PackageVersion Include="GitVersion.MsBuild" Version="6.8.1" />
   </ItemGroup>
   <ItemGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
     <PackageVersion Include="Terminal.Gui" Version="2.0.0" />

@@ -72,5 +72,18 @@ private IEnumerable<IFileSystemInfo> TryGetChildren (IFileSystemInfo entry)
         }
     }
 
-    internal static bool IsReparsePoint (IFileSystemInfo entry) => (entry.Attributes & FileAttributes.ReparsePoint) == FileAttributes.ReparsePoint;
+    internal static bool IsReparsePoint (IFileSystemInfo entry)
+    {
+        try
+        {
+            return (entry.Attributes & FileAttributes.ReparsePoint) == FileAttributes.ReparsePoint;
+        }
+        catch (Exception)
+        {
+            // Fail closed: if the reparse status cannot be read, treat the entry as a reparse point so
+            // callers do not traverse it — an unreadable symlink/junction could otherwise recreate the
+            // directory-cycle risk this guard exists to prevent.
+            return true;
+        }
+    }
 }
@@ -67,11 +67,14 @@ public Rectangle Frame
                 return;
             }
 
-            // BUGBUG: We set the internal fields here to avoid recursion. However, this means that
-            // BUGBUG: other logic in the property setters does not get executed.  Specifically:
-            // BUGBUG: - Reset TextFormatter
-            // BUGBUG: - SetLayoutNeeded (not an issue as we explicitly call Layout below)
-            // BUGBUG: - If we add property change events for X/Y/Width/Height they will not be invoked
+            // We set the internal fields directly (not via the X/Y/Width/Height setters) to avoid recursion.
+            // This is intentional and the two side effects of the setters are accounted for elsewhere (#5498):
+            // - TextFormatter constraints: recomputed by the Layout () -> SetRelativeLayout call below
+            //   (SetTextFormatterSize + FinalizeTextFormatterConstraints), so no reset is needed here.
+            // - Width/Height (and X/Y) change events: deliberately NOT raised here. Those events observe
+            //   declarative Dim/Pos assignment; this path overwrites them with Absolute values as bookkeeping
+            //   to keep state consistent with an imperatively-set Frame. Use FrameChanged (raised by SetFrame
+            //   above) to observe resolved-size changes from any cause.
             // If Frame gets set, set all Pos/Dim to Absolute values.
             _x = _frame!.Value.X;
             _y = _frame!.Value.Y;
@@ -152,6 +155,14 @@ protected virtual void OnFrameChanged (in Rectangle frame) { }
     ///     Raised when the <see cref="Frame"/> changes. This event is raised after the <see cref="Frame"/> has been
     ///     updated.
     /// </summary>
+    /// <remarks>
+    ///     This is the canonical event for observing resolved-size and position changes. It fires whenever the
+    ///     absolute <see cref="Frame"/> changes for any reason: assigning <see cref="X"/>, <see cref="Y"/>,
+    ///     <see cref="Width"/>, or <see cref="Height"/>; setting <see cref="Frame"/> directly; or a layout pass
+    ///     resolving a relative <see cref="Dim"/>/<see cref="Pos"/> (e.g. <see cref="DimFill"/>). By contrast, the
+    ///     <see cref="WidthChanged"/>/<see cref="HeightChanged"/> events observe assignment of the declarative
+    ///     <see cref="Width"/>/<see cref="Height"/> <see cref="Dim"/> only.
+    /// </remarks>
     public event EventHandler<EventArgs<Rectangle>>? FrameChanged;
 
     /// <summary>Gets the <see cref="Frame"/> with a screen-relative location.</summary>
@@ -368,6 +379,13 @@ public Pos Y
     ///         allowing customization or cancellation of the change. The <see cref="HeightChanging"/> event
     ///         is raised before the change, and <see cref="HeightChanged"/> is raised after.
     ///     </para>
+    ///     <para>
+    ///         <see cref="HeightChanging"/>/<see cref="HeightChanged"/> observe assignment of this declarative
+    ///         <see cref="Dim"/> only. They are deliberately not raised when a layout pass resolves the view's size
+    ///         or when <see cref="Frame"/> is set directly, because those paths change the resolved
+    ///         <see cref="Frame"/> rather than the declarative <see cref="Height"/>. To observe resolved-size
+    ///         changes from any cause, subscribe to <see cref="FrameChanged"/>.
+    ///     </para>
     ///     <para>The default value is <c>Dim.Absolute (0)</c>.</para>
     /// </remarks>
     /// <seealso cref="HeightChanging"/>
@@ -462,6 +480,13 @@ protected virtual void OnHeightChanged (ValueChangedEventArgs<Dim> args) { }
     ///         allowing customization or cancellation of the change. The <see cref="WidthChanging"/> event
     ///         is raised before the change, and <see cref="WidthChanged"/> is raised after.
     ///     </para>
+    ///     <para>
+    ///         <see cref="WidthChanging"/>/<see cref="WidthChanged"/> observe assignment of this declarative
+    ///         <see cref="Dim"/> only. They are deliberately not raised when a layout pass resolves the view's size
+    ///         or when <see cref="Frame"/> is set directly, because those paths change the resolved
+    ///         <see cref="Frame"/> rather than the declarative <see cref="Width"/>. To observe resolved-size
+    ///         changes from any cause, subscribe to <see cref="FrameChanged"/>.
+    ///     </para>
     ///     <para>The default value is <c>Dim.Absolute (0)</c>.</para>
     /// </remarks>
     /// <seealso cref="WidthChanging"/>
@@ -686,11 +711,14 @@ public bool SetRelativeLayout (Size superviewContentSize)
                 _suppressNeedsDrawAfterLayout = false;
             }
 
-            // BUGBUG: We set the internal fields here to avoid recursion. However, this means that
-            // BUGBUG: other logic in the property setters does not get executed.  Specifically:
-            // BUGBUG: - Reset TextFormatter
-            // BUGBUG: - SetLayoutNeeded (not an issue as we explicitly call Layout below)
-            // BUGBUG: - If we add property change events for X/Y/Width/Height they will not be invoked
+            // We update the internal fields directly (not via the X/Y/Width/Height setters) to avoid recursion.
+            // This is intentional and the two side effects of the setters are accounted for here (#5498):
+            // - TextFormatter constraints: already recomputed by SetTextFormatterSize () above and finalized by
+            //   FinalizeTextFormatterConstraints () below, so no reset is needed here.
+            // - Width/Height (and X/Y) change events: deliberately NOT raised. A layout pass resolves the Frame
+            //   without changing the declarative Dim/Pos (e.g. Dim.Fill () stays Dim.Fill ()); these assignments
+            //   only collapse an already-Absolute dim onto its resolved value. FrameChanged (raised by SetFrame
+            //   above) is the event for resolved-size changes.
             if (_x is PosAbsolute)
             {
                 _x = Frame.X;

@@ -103,7 +103,9 @@ public CharMap ()
         KeyBindings.Add (Key.PageDown, Command.PageDown);
         KeyBindings.Add (Key.Home, Command.Start);
         KeyBindings.Add (Key.End, Command.End);
-        KeyBindings.Add (PopoverMenu.DefaultKey, Command.Context);
+        // ReplaceCommands, not Add: PopoverMenu.DefaultKey is configurable and may collide with a key
+        // that is already bound (e.g. Ctrl+P); the user's context-menu key wins.
+        KeyBindings.ReplaceCommands (PopoverMenu.DefaultKey, Command.Context);
 
         MouseBindings.ReplaceCommands (MouseFlags.LeftButtonClicked, Command.Activate);
         MouseBindings.Add (MouseFlags.LeftButtonDoubleClicked, Command.Accept);

@@ -231,7 +231,10 @@ internal FileDialog (IFileSystem? fileSystem)
         // by default, Runnable doesn't bind to Command.Context, so
         // we can take advantage of the CommandNotBound event to handle it
         _tableView.CommandNotBound += TableViewHandleCommandNotBound;
-        _tableView.KeyBindings.Add (PopoverMenu.DefaultKey, Command.Context);
+
+        // ReplaceCommands, not Add: PopoverMenu.DefaultKey is configurable and may collide with a key
+        // TableView already binds (e.g. Ctrl+P -> Command.Up); the user's context-menu key wins.
+        _tableView.KeyBindings.ReplaceCommands (PopoverMenu.DefaultKey, Command.Context);
         _tableView.MouseBindings.Add (MouseFlags.RightButtonClicked, Command.Context);
 
         _tbPath.TextChanged += (_, _) => PathChanged ();

@@ -4,6 +4,10 @@ namespace Terminal.Gui.Views;
 
 internal class FileDialogState
 {
+    // AttributesToSkip defaults to Hidden | System; clear it so hidden/system entries (e.g. dotfiles on Unix)
+    // remain visible, matching the behavior of the GetDirectories ()/GetFileSystemInfos () calls this replaced.
+    private static readonly EnumerationOptions _ignoreInaccessibleEnumerationOptions = new () { IgnoreInaccessible = true, AttributesToSkip = FileAttributes.None };
+
     public FileDialogState (IDirectoryInfo dir, FileDialog parent)
     {
         Parent = parent;
@@ -60,17 +64,31 @@ private void AddReadableChildren (List<FileSystemInfoStats> children, IDirectory
     {
         try
         {
-            IEnumerable<IFileSystemInfo> entries;
-
-            // if directories only
-            if (Parent.OpenMode == OpenMode.Directory)
-            {
-                entries = dir.GetDirectories ();
-            }
-            else
+            foreach (IFileSystemInfo entry in EnumerateReadableEntries (dir))
             {
-                entries = dir.GetFileSystemInfos ();
+                AddReadableChild (children, entry);
             }
+        }
+        catch (NotSupportedException)
+        {
+            // Some IFileSystem implementations (e.g. System.IO.Abstractions.TestingHelpers MockFileSystem)
+            // do not support clearing EnumerationOptions.AttributesToSkip; fall back to the eager listing
+            // methods, which never skip hidden/system entries.
+            AddReadableChildrenEagerly (children, dir);
+        }
+        catch (Exception)
+        {
+            // Access permission exceptions, missing directories, etc.
+        }
+    }
+
+    private void AddReadableChildrenEagerly (List<FileSystemInfoStats> children, IDirectoryInfo dir)
+    {
+        try
+        {
+            IEnumerable<IFileSystemInfo> entries = Parent.OpenMode == OpenMode.Directory
+                                                       ? dir.GetDirectories ()
+                                                       : dir.GetFileSystemInfos ();
 
             foreach (IFileSystemInfo entry in entries)
             {
@@ -83,6 +101,17 @@ private void AddReadableChildren (List<FileSystemInfoStats> children, IDirectory
         }
     }
 
+    private IEnumerable<IFileSystemInfo> EnumerateReadableEntries (IDirectoryInfo dir)
+    {
+        // if directories only
+        if (Parent.OpenMode == OpenMode.Directory)
+        {
+            return dir.EnumerateDirectories ("*", _ignoreInaccessibleEnumerationOptions);
+        }
+
+        return dir.EnumerateFileSystemInfos ("*", _ignoreInaccessibleEnumerationOptions);
+    }
+
     private void AddReadableChild (List<FileSystemInfoStats> children, IFileSystemInfo entry)
     {
         try

@@ -0,0 +1,58 @@
+// Claude - Opus 4.8
+
+using System.IO.Abstractions.TestingHelpers;
+using Terminal.Gui.Configuration;
+
+namespace ConfigurationTests;
+
+/// <summary>
+///     Verifies that views binding <see cref="PopoverMenu.DefaultKey"/> to <see cref="Command.Context"/>
+///     do not throw when the configured key collides with a key the view already binds
+///     (e.g. Ctrl+P, which <see cref="TableView"/> binds to <see cref="Command.Up"/> by default).
+/// </summary>
+[Collection ("StaticSettingsTests")]
+public class PopoverMenuDefaultKeyCollisionTests
+{
+    [Fact]
+    public void FileDialog_Ctor_DoesNotThrow_WhenDefaultKeyCollidesWithTableViewBinding ()
+    {
+        PopoverMenuSettings original = PopoverMenuSettings.Defaults;
+
+        try
+        {
+            // TableView binds Ctrl+P -> Command.Up by default; the context-menu key must win without throwing.
+            PopoverMenuSettings.Defaults = new () { DefaultKey = Key.P.WithCtrl };
+
+            MockFileSystem fs = new ();
+            fs.AddDirectory ("/testdir");
+
+            using FileDialog fd = new (fs);
+
+            Assert.NotNull (fd);
+        }
+        finally
+        {
+            PopoverMenuSettings.Defaults = original;
+        }
+    }
+
+    [Fact]
+    public void CharMap_Ctor_DoesNotThrow_WhenDefaultKeyCollidesWithExistingBinding ()
+    {
+        PopoverMenuSettings original = PopoverMenuSettings.Defaults;
+
+        try
+        {
+            // CharMap binds Key.End -> Command.End before binding the context-menu key.
+            PopoverMenuSettings.Defaults = new () { DefaultKey = Key.End };
+
+            using CharMap charMap = new ();
+
+            Assert.NotNull (charMap);
+        }
+        finally
+        {
+            PopoverMenuSettings.Defaults = original;
+        }
+    }
+}
@@ -0,0 +1,11 @@
+namespace ConfigurationTests;
+
+[CollectionDefinition ("StaticSettingsTests", DisableParallelization = true)]
+public class StaticSettingsTestCollection
+{
+    // Marker collection for tests that mutate process-wide static settings facades
+    // (e.g. DriverSettings.Defaults, PopoverMenuSettings.Defaults). Without
+    // DisableParallelization, these tests race views constructed in parallel tests —
+    // e.g. temporarily making PopoverMenu.DefaultKey read Ctrl+P while a FileDialog
+    // is being constructed elsewhere.
+}
@@ -0,0 +1,49 @@
+using System.IO.Abstractions;
+using Moq;
+
+namespace FileServicesTests;
+
+public class FileSystemTreeBuilderTests
+{
+    [Fact]
+    public void CanExpand_DirectoryWithUnreadableAttributes_DoesNotThrowAndReturnsFalse ()
+    {
+        Mock<IDirectoryInfo> directory = new ();
+        directory.SetupGet (d => d.Attributes).Throws (new UnauthorizedAccessException ("Access denied"));
+        directory.SetupGet (d => d.Exists).Returns (true);
+        directory.Setup (d => d.GetFileSystemInfos ()).Returns ([]);
+
+        FileSystemTreeBuilder builder = new ();
+
+        bool canExpand = builder.CanExpand (directory.Object);
+
+        Assert.False (canExpand);
+    }
+
+    [Fact]
+    public void GetChildren_DirectoryWithUnreadableAttributes_DoesNotThrowAndReturnsEmpty ()
+    {
+        Mock<IDirectoryInfo> directory = new ();
+        directory.SetupGet (d => d.Attributes).Throws (new UnauthorizedAccessException ("Access denied"));
+        directory.SetupGet (d => d.Exists).Returns (true);
+        directory.Setup (d => d.GetFileSystemInfos ()).Returns ([]);
+
+        FileSystemTreeBuilder builder = new ();
+
+        IEnumerable<IFileSystemInfo> children = builder.GetChildren (directory.Object);
+
+        Assert.Empty (children);
+    }
+
+    // Claude - Opus 4.8
+    [Fact]
+    public void IsReparsePoint_WhenAttributesUnreadable_FailsClosed ()
+    {
+        Mock<IDirectoryInfo> directory = new ();
+        directory.SetupGet (d => d.Attributes).Throws (new UnauthorizedAccessException ("Access denied"));
+
+        // Fail closed: an entry whose reparse status cannot be read must be treated as a reparse
+        // point so callers (CanExpand, GetChildren, FileDialog search) do not traverse it.
+        Assert.True (FileSystemTreeBuilder.IsReparsePoint (directory.Object));
+    }
+}