feat (counter): Support for cpumask #271
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
cpumask
field of PMU events.Some PMUs do not refer to a core component but to some piece of uncore, such as the
amd_iommu_0
PMU found on modern AMD processors.To be able to still measure them, perf associates every uncore PMU with a logical core. This relationship is recorded in the
cpumask
field.This PR makes lo2s respect this
cpumask
field, only opening the PMU events on the cores recorded incpumask
.Note that this works as both
-E
and--userspace-metric-event
.This PR is marked DRAFT for these reasons:
--list-events
looks?Currently it prints something like this:
This PR does not address the second part of Issue #262, which is support for uncore events in process mode.
I think before we attempt to band-aid fix support for such a system-mode event in process mode we should have a discussion about a more general solution to combining system-mode and process mode measurements.