Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.12 #17

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Support ghc 9.12 #17

merged 2 commits into from
Jan 5, 2025

Conversation

erikd
Copy link

@erikd erikd commented Dec 8, 2024

No description provided.

@Fuuzetsu
Copy link
Member

GHC 9.12 doesn't seem to be available at https://github.com/haskell-actions/setup yet. I think it's not actually released yet. Should we wait a bit with this PR?

@Fuuzetsu
Copy link
Member

I guess we can mark the action as allowed to fail: as long as old versions still work then everyone using unreleased version is sort of on their own already but it'd be nice to make it work for them.

@erikd
Copy link
Author

erikd commented Dec 10, 2024

This PR can wait until the official ghc-9.12 release (due next week I believe) or that job can be marked as failable.

The thing that would help me the most is a metadata edit on Hackage to allow newer versions of base and template-haskell.

@Fuuzetsu
Copy link
Member

This PR can wait until the official ghc-9.12 release (due next week I believe) or that job can be marked as failable.

The thing that would help me the most is a metadata edit on Hackage to allow newer versions of base and template-haskell.

Done; TH was already at the bumped version: https://hackage.haskell.org/package/vector-th-unbox-0.2.2/revisions/

@erikd
Copy link
Author

erikd commented Dec 10, 2024

Sorry, the PR was wrong. TH does need to be bumped.

I have updated the PR and would appreciate a Hackage metadata edit as well.

@Fuuzetsu
Copy link
Member

Sorry, the PR was wrong. TH does need to be bumped.

Is there a reason why you made the lower bound less restrictive than it was?

@Fuuzetsu
Copy link
Member

I bumped the upper bound on Hackage for now

@erikd
Copy link
Author

erikd commented Dec 11, 2024

Is there a reason why you made the lower bound less restrictive than it was?

Sorry fixed.

@Fuuzetsu
Copy link
Member

Great. Let's wait for 9.12 before hitting merge then. Thanks. Feel free to remind me as I'll inevitably forget to check.

@erikd
Copy link
Author

erikd commented Dec 16, 2024

ghc-9.12.1 has been released, Wonder if it is available in CI yet.

@Fuuzetsu
Copy link
Member

Not yet: haskell-actions/setup#98 (comment)

@erikd
Copy link
Author

erikd commented Jan 5, 2025

@Fuuzetsu If this fails in CI again for ghc-9.12 I recommend redoing the whole of the CO job with the haskell-ci tool (I will do it).

@erikd
Copy link
Author

erikd commented Jan 5, 2025

🎉 All ready to go!!!

@Fuuzetsu Fuuzetsu merged commit 61c49d9 into tsurucapital:master Jan 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants