Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More UI improvements and better dev mode #38

Merged
merged 28 commits into from
Jun 7, 2024
Merged

Conversation

typeholes
Copy link
Collaborator

fixes #37

grid like layout for trace lines

somewhat reactive to page width, but still scrolls when too narrow.

srcDev package launches a bridge between the extension and ui:dev so you get bidirectional communication instead of the fixed commands/responses we had before

@typeholes typeholes requested a review from danielroe June 3, 2024 16:40
@typeholes
Copy link
Collaborator Author

If you think the UI is up to par, please move the UI commands out of experimental

@typeholes typeholes marked this pull request as draft June 4, 2024 03:50
@typeholes
Copy link
Collaborator Author

Something seems off with the tree nesting in more complicated repos, investigating ...

@typeholes typeholes removed the request for review from danielroe June 4, 2024 03:51
@typeholes
Copy link
Collaborator Author

I've verified that the data is correct. It looks like a reactive effect isn't getting triggered consistently.

use vue reactivity on the backend to ensure updates
move event handles to a central state
@typeholes
Copy link
Collaborator Author

fixed reactivity and listener issues. performance is much better now as well.
sorting no longer triggers a fetch of the nodes. Will undraft after a test pass

@typeholes
Copy link
Collaborator Author

one last bug to fix in the morning: trace file names get duplicated in the UI when switching projects - need to move listener and state to appState.ts

@typeholes typeholes requested a review from danielroe June 5, 2024 15:33
@typeholes typeholes marked this pull request as ready for review June 5, 2024 15:33
@danielroe
Copy link
Member

danielroe commented Jun 7, 2024

Looking good! A couple of comments.

  • click targets should be bigger on the expand/goto buttons
  • I think there's something wrong with the relative path that's being printed - it should be something like index.ts rather than ../../../../../../users/daniel/code/tsperf/tracer/playground/index.ts
  • 'go to trace' still doesn't seem to work with split screen view
  • if I run 'tsc trace' and then open the viewer I don't see anything - nothing appears to have happened... - it only seems to work if the viewer is open and then I run 'tsc trace'
CleanShot.2024-06-07.at.08.51.28.mp4

@danielroe danielroe merged commit 38f2593 into tsperf:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hover and focus styles for icons
2 participants