Unified logic for "Off"-point start #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering didn't change, code simplified
Here is a thing: both cases On&On and Off&Off for two nearest points leads us to get an average point between them.
Instead of handling lines (On&On) separately, let's turn them into degenerate quadratic curves by inserting a midpoint. That allows us to eliminate SEGMENT_LINE logic completely and treat everything uniformly as quadratic Béziers.
Furthermore, the algorithm acts as a two-point sliding window (cp1, cp2) that analyzes the previous and current contour points to decide how to form the next Segment. This allows us to reduce code repetition..