Update glossary.md #3340
Open
Update glossary.md #3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference ARGs in the glossary
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 29 29
Lines 31289 31289
Branches 5737 5737
=======================================
Hits 28086 28086
Misses 1794 1794
Partials 1409 1409
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| aligned DNA sequences. The name reflects the idea that a common | ||
| way to treat genetic ancestry is as a sequence of correlated | ||
| "trees" along the genome; a tree sequence provides an efficient | ||
| way to store differences between these trees. Technically, ancestry |
Member
There was a problem hiding this comment.
Suggested change
| way to store differences between these trees. Technically, ancestry | |
| way to store shared branches between these trees. Technically, ancestry |
The edge table is storing what is shared, not what is different across local trees. I know this is nitpicking, but thinking in terms of differences I have read in many places really confused me when I started to read about what is tree sequence. The left-right algorithms work with differences, I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference ARGs in the glossary when defining a "tree sequence". I hope this clarifies rather than adds to any confusion.
We can address the "what is a tree sequence" stuff in the tutorials too.