Repository navigation
Report actionable SysConfig pin errors without source IDs or stack traces - #257
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
test with inline snapshots |
ShiboSoftwareDev
approved these changes
Oct 6, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ti generate-sysconfigencounters connected MCU pins without selected functions, it previously printed generated record IDs, Bun source excerpts and a stack trace. Bundle the actionable converter from converter PR #9 at commit3da9ac4b464a84eac13615dc684da7105065c685, and report its message with a nonzero exit status.Before:
After, for two connected pins without selected functions:
Add
toMatchInlineSnapshot()assertions for complete terminal errors from both Circuit JSON and TSX inputs. Also assert exit status 1, empty stdout and no partial.syscfgfile. Include these Bun tests in the existingtest:clicommand alongside the Node CLI suite and schematic snapshot.Validation:
tscircuit@0.0.2745.This PR is limited to error reporting and its regression coverage. Pin capability behavior and datasheet metadata follow-ups are separate work. Nothing has been released.