Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
force-pushed
the
fix/canonical-chip-props
branch
from
October 3, 2026 18:53
2c1047f to
b575574
Compare
|
The latest updates on your projects. Learn more about tscircuit for Git ↗︎
📦 Built with tscircuit |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ChipPropsfrom@tscircuit/propsconsistently in the remaining chip wrappers, and declare that package as a peer. The other wrappers already use this canonical import.Importing props through the aggregate
tscircuitpackage can bind to its older nested props/Circuit JSON types. That makes valid component props incompatible with a host using newer voltage types or DDR metadata. Direct peer imports keep the wrappers aligned with the host without dependency overrides.This changes type imports and dependency declarations only; pins, footprints, placement and routing are unchanged. It unblocks the host type check for tscircuit/core#4346.
The branch is based on core's pinned TI revision so the integration dependency preserves existing component layouts. The PR changes only canonical type imports and props dependency declarations.