Repository navigation
Fix pedometer SysConfig requests and open-drain conversion - #252
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShiboSoftwareDev
approved these changes
Oct 1, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After building
imrishabh18/pedometerv1.1.3,ti generate-sysconfig ./index.circuit.tsxreports a missing request even thoughdist/index/circuit.jsonexists. The message does not explain that the missing file supplies firmware behavior. With a request supplied, the board's valid open-drain I2C declarations also fail conversion.This change explains hardware Circuit JSON versus firmware requests, identifies missing explicit
--configpaths accurately, and supplies a testedindex.sysconfig.jsonfor the current board'sU1component and signal names. It updates the bundled converter pin tob4458ed78fdcfeee3404af45bf30b36e06349c7d, allowing open-drain SDA/SCL while preserving incompatible GPIO checks.Dependency: merge circuit-json-to-sysconfig #6 first. The separate pre-build missing-export crash is addressed by eval #4905. This is a follow-up to merged #250.
Validation: 30 Node CLI tests plus the imported-component snapshot pass; formatting, typecheck, and npm package build pass. New regression tests cover missing requests after a successful TSX build, an invalid explicit request path, and open-drain I2C through the CLI. The final built npm CLI, using the committed request file and converter revision, passes both generate and real TI check on pedometer v1.1.3 with Bun 1.3.14. SysConfig 1.28.1+4785 / SimpleLink F3 SDK 9.21.00.36 generates seven files and semantic checking passes.
The example explicitly selects display isolation high, PMIC low-power low, accelerometer input, I2C at 100 kbit/s, reserved SWD pins, NoRTOS, and internal LF RCOSC. It is a configuration example, not a complete pedometer firmware application. The converter remains bundled at build time, so npm consumers do not fetch the Git dependency.