feat: expose extended promotional components#344
Open
jonahsills wants to merge 5 commits into
Open
Conversation
Author
|
Follow-up CI note: the latest run on 48d2237 is now fully green (format-check, type-check, and Bun Test). The CI-only fix keeps the shared DB alive during test preload while preserving CLI cleanup behavior for scripts/setup-derived-tables.ts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #92
Summary
is_extended_promotionalresponse field derived from existing JLC flags (preferred = 1andbasic = 0)/components/listand/api/search/api/searchand/components/list, including HTML filter/column renderingNotes
This keeps the feature change schema-light: the source tables already expose
basicandpreferred, so the extended-promotional value is computed consistently instead of requiring a new migration.Validation
git diff --checkcd cf-proxy && npx tsc --noEmitcd cf-proxy && npx vitest run test/render.test.ts --config vitest.node.config.mtswith a temporary Node-only Vitest config for the pure render test: 4 tests passedcurl -Ichecks confirmed the old7z2408-linux-x64.tar.xzURL returns 404 and the replacement7z2601Linux/macOS URLs return 200No space left on devicesetup failure by freeing preinstalled toolchains before DB setupThe default cf-proxy Vitest worker config could not run locally because the Workers runtime failed to import
node:vm; the focused render test passes under the Node pool. Roottscis noisy on this repo without the Bun dependency environment, so CI remains the source of truth for the root Bun test.