Skip to content

feat: expose extended promotional components#344

Open
jonahsills wants to merge 5 commits into
tscircuit:mainfrom
jonahsills:jonahsills/issue-92-extended-promotional
Open

feat: expose extended promotional components#344
jonahsills wants to merge 5 commits into
tscircuit:mainfrom
jonahsills:jonahsills/issue-92-extended-promotional

Conversation

@jonahsills
Copy link
Copy Markdown

@jonahsills jonahsills commented May 29, 2026

/claim #92

Summary

  • add an is_extended_promotional response field derived from existing JLC flags (preferred = 1 and basic = 0)
  • expose/filter the flag in origin /components/list and /api/search
  • pass the same filter through D1 /api/search and /components/list, including HTML filter/column rendering
  • add focused render coverage for the D1 components filter
  • update the setup script from removed 7-Zip 24.08 download URLs to current 26.01 URLs so CI can fetch 7z and run tests
  • stabilize the Bun test workflow by freeing runner disk, installing cf-proxy dependencies, allowing setup cache fallback, and giving fresh DB setup enough time to finish

Notes

This keeps the feature change schema-light: the source tables already expose basic and preferred, so the extended-promotional value is computed consistently instead of requiring a new migration.

Validation

  • git diff --check
  • cd cf-proxy && npx tsc --noEmit
  • cd cf-proxy && npx vitest run test/render.test.ts --config vitest.node.config.mts with a temporary Node-only Vitest config for the pure render test: 4 tests passed
  • curl -I checks confirmed the old 7z2408-linux-x64.tar.xz URL returns 404 and the replacement 7z2601 Linux/macOS URLs return 200
  • checked failed GitHub Actions annotation and addressed the runner No space left on device setup failure by freeing preinstalled toolchains before DB setup

The default cf-proxy Vitest worker config could not run locally because the Workers runtime failed to import node:vm; the focused render test passes under the Node pool. Root tsc is noisy on this repo without the Bun dependency environment, so CI remains the source of truth for the root Bun test.

@jonahsills
Copy link
Copy Markdown
Author

Follow-up CI note: the latest run on 48d2237 is now fully green (format-check, type-check, and Bun Test). The CI-only fix keeps the shared DB alive during test preload while preserving CLI cleanup behavior for scripts/setup-derived-tables.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant