Add extended promotional boolean filter#339
Open
YunHeTracyLee wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #92
Summary
is_extended_promotionalfrom existing JLC flags aspreferred = 1andbasic = 0./components/listand/api/searchresponses, includingfull=truecomponents-list responses.is_extended_promotional=trueandis_extended_promotional=falsefiltering in the origin routes and D1 proxy search/catalog paths.Non-overlap
Most existing #92 PRs cover the true-only checkbox/filter path. This PR keeps the same derived-field behavior but makes the query filter a full boolean API (
trueandfalse) while keeping the UI checkbox path intact.Validation
npx --yes bun test tests/lib/extended-promotional.test.tsnpx --yes bun x biome check lib/util/extended-promotional.ts routes/components/list.tsx routes/api/search.tsx tests/lib/extended-promotional.test.ts cf-proxy/src/extended-promotional.ts cf-proxy/src/search.ts cf-proxy/src/components.ts cf-proxy/src/index.ts cf-proxy/src/render.ts cf-proxy/test/render.test.tsnpx --yes bun x tsc --noEmitcd cf-proxy && npx --yes bun x tsc --noEmit && npx --yes bun test test/render.test.tsgit diff --checkAI-assisted with Codex; I reviewed the diff and validation before submitting.