feat: add is_extended_promotional column and filter to components#337
Open
khozakhulile27-netizen wants to merge 33 commits into
Open
Conversation
…ver has already been destroyed' in CI tests)
…setup-derived-tables)
… for cf-proxy tests
Author
|
Please review |
Author
|
Please I fix everything am requesting a review |
Author
|
@seveibar please review |
Author
|
@seveibar - Please review this PR when you have a moment. 🙏 This PR (#337) implements the
Ready for merge! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
What this adds
Some JLCPCB parts are "extended promotional" — they act as basic parts for a limited time. This PR exposes that data as a filterable column.
Changes
lib/db/derivedtables/component-base.ts— addsis_extended_promotional: booleanto theBaseComponentinterfacelib/db/optimizations/component-extended-promotional-index.ts— new optimization that:is_extended_promotionalcolumn to thecomponentstable viaALTER TABLEif it doesn't existroutes/components/list.tsx— addsis_extended_promotionalas an optional boolean query param that filters resultsUsage