feat: add is_extended_promotional to search results#334
Open
voltrace-io wants to merge 1 commit into
Open
Conversation
…utes Adds is_extended_promotional boolean column across the entire codebase: - BaseComponent interface: added is_extended_promotional field - All 37 derived table specs: added column to extraColumns and computed in mapToTable as Boolean(c.preferred) && !Boolean(c.basic) - Generated Kysely types: added is_extended_promotional to all component interfaces - Routes (resistors, capacitors, resistor_arrays, components, api/search): added filter parameter, query filter, JSON response field, and UI checkbox Extended promotional parts are preferred parts that are not basic, meaning they temporarily act as basic parts with reduced fees. Closes tscircuit#92 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
/claim #92
Summary
Adds
is_extended_promotionalsupport across the jlcsearch derived-table/search pipeline.This PR adds the boolean field to the derived tables and exposes it through the relevant search routes for:
Changes
is_extended_promotionalto all derived tablesValidation
The failing tests appear to be pre-existing stub DB failures and reproduce on
main, so they do not appear to be introduced by this PR.