Keep JSON links relative#333
Open
ProtonsAndElectrons wants to merge 7 commits into
Open
Conversation
Author
|
CI is green now ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #27
Summary
jsonlink path-relative instead of deriving it from the full request URL24.08to25.01so the required Bun Test workflow can run on cache missesValidation
bun test cf-proxy/test/render.test.tsbun test test/render.test.ts(fromcf-proxy)bunx biome format lib/middlewares/with-ctx-react.tsx cf-proxy/src/render.ts cf-proxy/test/render.test.tsbunx tsc --noEmitcd cf-proxy && bunx tsc --noEmit7z2501-linux-x64.tar.xz,7z2501-linux-arm64.tar.xz, and7z2501-mac.tar.xzreturning 200http://.../components/listrendershref="/components/list.json?..."git diff --checkNote:
bun run format:check ...invokes the repo-widebiome format .; on this Windows checkout it reports pre-existing CRLF-only diagnostics across unrelated files, so I used direct Biome checking for the touched files above. CI format check is passing on the Linux checkout.AI-assisted with Codex; scoped to the relative JSON-link behavior plus the minimal CI setup URL refresh needed for the test job.