Add extended promotional component flag#326
Open
Haenlein1 wants to merge 2 commits into
Open
Conversation
Author
|
CI status update:
This looks like the setup dependency download step rather than a test failure from this PR's code path. |
Author
|
Follow-up pushed in What changed:
Local verification:
One local limitation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
is_extended_promotionalcomponent column derived from source metadata.is_extended_promotionalin/components/listand/api/searchresponses and supportsis_extended_promotional=truefiltering.Why it fixes the issue
Issue #92 asks for extended promotional parts to be available in a filterable column. This adds that column during DB optimization, keeps it indexed for filtering, and makes the field available through both the legacy app routes and the Cloudflare proxy/search paths.
Tested
npx @biomejs/biome format --writeon touched filesnpx tsc --noEmitcd cf-proxy && npx tsc --noEmitgit diff --checkLimitations
cf-proxyVitest startup is blocked in my local Windows workspace by the Cloudflare/Vitest worker loader resolving the username path with a space; the suite starts after optional native dependencies are installed but fails before collecting tests./claim #92
Bounty: #92