Repository navigation
fix: require series connectivity before diode/resistor alignment - #192
Open
MustafaMulla29 wants to merge 3 commits into
Open
MustafaMulla29 wants to merge 3 commits into
MustafaMulla29 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
added this pull request to stack #196
October 6, 2026 06:28
This was referenced Oct 6, 2026
seveibar
requested changes
Oct 6, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
why would these be removed? There are snapshots updated that didn't change
Contributor
Author
|
@seveibar You're right—the parallel layout should still be flagged. This removes incorrect series-alignment advice; #198 adds the proper parallel-layout warning for this exact D1/R4 case. #192 shouldn't land without that replacement. The unchanged-looking Trellis snapshots only changed because global issue numbers shifted. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #191.
Parallel diode/resistor pairs and separate branches on a common supply should not receive series-alignment advice. Resolve actual connected terminals through the existing source connectivity index, require a non-rail junction with exactly two terminals and distinct outer nets, then check the pin geometry. Ambiguous or multiply drawn placements are not guessed from nearby wire endpoints.
This removes the global nearest-pin search and duplicate findings from multiple wire segments. Component types and source IDs establish the topology; names and pin labels are used only in diagnostics. The native repro now shows zero warnings for the parallel and branched cases and one for the misaligned series pair. Existing direct-wire and named-net series tests still pass.
Validation: 163 tests passed; TypeScript and formatting checks passed (two existing oversized-fixture notices). Snapshots retain their diagnostic sections, including zero counts.