Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecmascript): Implement parseFloat #459

Merged
merged 3 commits into from
Nov 10, 2024
Merged

feat(ecmascript): Implement parseFloat #459

merged 3 commits into from
Nov 10, 2024

Conversation

eliassjogreen
Copy link
Member

@eliassjogreen eliassjogreen commented Nov 10, 2024 •
edited
Loading

Uses fast_float.

@aapoalas
Copy link
Collaborator

Damn, seems like a strict equality comparison isn't enough as "infinity" also must not parse into Infinity.

@eliassjogreen
Copy link
Member Author

Dang, pushed a fix.

@aapoalas aapoalas merged commit 8d6c2a3 into trynova:main Nov 10, 2024
1 check passed
@aapoalas
Copy link
Collaborator

Thank you very much! Awesome work! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliassjogreen @aapoalas