⚡ Optimize permission setting to avoid redundant scans#12
Conversation
This change replaces the global `set_perm_recursive` call on `$MODPATH` with a `find` command that uses `-prune` to exclude subdirectories (like `system/lib`, `system/vendor/firmware`) which are handled by subsequent specific permission calls. This prevents double-scanning of large directory trees, improving installation performance. Benchmark results show a reduction in file system traversal overhead. Also added `tests/benchmark_permissions.sh` to measure and verify the performance improvement. Co-authored-by: tryigit <40565628+tryigit@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Replaced global
set_perm_recursivewith an optimizedfindcommand that prunes specific subdirectories to avoid redundant permission setting. Added a benchmark script to verify the performance gain.PR created automatically by Jules for task 13781992671763745822 started by @tryigit