Conversation
- Added `ro.hardware.vulkan=adreno` and `ro.hardware.egl=adreno` to `Magisk Template/system.prop` to enforce Adreno driver usage. - Updated `Magisk Template/customize.sh` to explicitly set `u:object_r:same_process_hal_file:s0` context for `egl` and `hw` subdirectories in `system/vendor/lib` and `system/vendor/lib64`. - Updated `README.md` to mark the "Magiskhide map conflict" issue as resolved. - Added `tests/verify_prop.sh` to verify system properties. Co-authored-by: tryigit <40565628+tryigit@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
This change addresses the "Magiskhide map conflict" issue by ensuring that the GPU driver libraries have the correct SELinux context (
same_process_hal_file) even for subdirectories likeeglandhw, which helps with MagiskHide/Zygisk compatibility. Additionally,ro.hardware.vulkanandro.hardware.eglproperties are set toadrenoto ensure the system consistently loads the correct driver implementation. Verified with new property check script and existing verification script.PR created automatically by Jules for task 13274630152753395397 started by @tryigit