Make it possible to use node-fetch in HTTPService #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
slaesh
reviewed
Jul 13, 2023
packages/core/src/index.ts
Outdated
| @@ -61,13 +55,27 @@ export class Abby< | |||
| TestName extends string, | |||
| Tests extends Record<string, ABConfig> | |||
| > { | |||
| constructor( | |||
There was a problem hiding this comment.
constructor usally comes between the variables and the functions of a class
slaesh
reviewed
Jul 13, 2023
| type: AbbyEventType; | ||
| data: Omit<AbbyEvent, "type">; | ||
| }) { | ||
| this.httpService.sendData({ url, type, data }); |
There was a problem hiding this comment.
Suggested change
| this.httpService.sendData({ url, type, data }); | |
| return this.httpService.sendData({ url, type, data }); |
slaesh
reviewed
Jul 13, 2023
slaesh
reviewed
Jul 13, 2023
slaesh
approved these changes
Jul 13, 2023
Co-authored-by: slaesh <[email protected]>
Co-authored-by: slaesh <[email protected]>
…om/tryabby/abby into feat/core/add_fetch_to_constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR updates the implementation of the HttpService in the Core package to utilize an optionally passed fetch function.
The changes are needed in order to prepare for the upcoming NodeJs SDK which relies on using the core.
Add parameter and fix tests