Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: proper log level in auth #96

Closed
wants to merge 1 commit into from
Closed

chore: proper log level in auth #96

wants to merge 1 commit into from
+1 −1

Conversation

helio-frota
Copy link
Collaborator

No description provided.

@helio-frota
chore: proper log level in auth
Loading
Loading status checks…
d8317ed
@helio-frota helio-frota requested a review from ctron March 19, 2024 14:32
ctron
ctron requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should raise that as an error in the logs.

Assuming someone sends us unverifiable tokens. We should just ignore them, without spamming our logs with errors.

@helio-frota
Copy link
Collaborator Author

helio-frota commented Mar 19, 2024 •
edited
Loading

Assuming someone sends us unverifiable tokens. We should just ignore them

makes sense 👍 thanks

@helio-frota helio-frota deleted the log-level branch March 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@helio-frota @ctron