Replace GraphMap’s map with a moka::sync::Cache #1224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add some tests around the cache eviction edge cases:
|
… safe. Signed-off-by: Hiram Chirino <[email protected]>
This is needed since the graph map may evict an entry after it’s loaded. This allows The request to hold onto all the graphs need to process the current request. Signed-off-by: Hiram Chirino <[email protected]>
…tions. Signed-off-by: Hiram Chirino <[email protected]>
chirino
commented
Jan 31, 2025
Comment on lines
+44
to
+66
| pub(crate) fn set_approximate_memory_size(&self) -> PackageNode { | ||
| // Is there a better way to do this? | ||
| let size = size_of::<PackageNode>() | ||
| + self.sbom_id.len() | ||
| + self.node_id.len() | ||
| + self.purl.iter().fold(0, |acc, purl| | ||
| // use the json string length as an approximation of the memory size | ||
| acc + serde_json::to_string(purl).unwrap_or_else(|_| "".to_string()).len()) | ||
| + self.cpe.iter().fold(0, |acc, cpe| | ||
| // use the json string length as an approximation of the memory size | ||
| acc + serde_json::to_string(cpe).unwrap_or_else(|_| "".to_string()).len()) | ||
| + self.name.len() | ||
| + self.version.len() | ||
| + self.published.len() | ||
| + self.document_id.len() | ||
| + self.product_name.len() | ||
| + self.product_version.len(); | ||
|
|
||
| PackageNode { | ||
| approximate_memory_size: size.try_into().unwrap_or(u32::MAX), | ||
| ..self.clone() | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a better way to estimate how much memory this thing uses up?
There was a problem hiding this comment.
Kinda assuming that saving the approximate_memory_size will give us savings later, it might not.
This allows test results to be consistent. Signed-off-by: Hiram Chirino <[email protected]>
|
@JimFuller-RedHat I think I'm happy with this now. I'm going to keep it draft until #1217 goes in so you guys don't suffer the conflicts. But if you have idle time maybe worth a gander in case you think this went in the wrong direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1218