Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsonpath in tests #1220

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

jcrossley3
Copy link
Contributor

Better, worse, or same?

Better, worse, or same?

Signed-off-by: Jim Crossley <[email protected]>
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me (being a fan of xpath I would say that) ...

@helio-frota
Copy link
Collaborator

helio-frota commented Jan 30, 2025

I tend to think this is Better also because we don't have full control over a typo in the previous approach. example: .filter(|d| d["relationshiip"] == "GeneratedFron")

@helio-frota helio-frota self-requested a review January 30, 2025 18:06
@jcrossley3 jcrossley3 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into trustification:main with commit 950223b Jan 31, 2025
3 of 4 checks passed
@jcrossley3 jcrossley3 deleted the jsonpath-test branch January 31, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants