More test cleanup; removing hardcoded array indexing #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to further constrain the results without assuming any particular order in the output. Signed-off-by: Jim Crossley <[email protected]>
| panic!("one of the items component should have matched."); | ||
| } | ||
| log::info!("{:?}", response); | ||
| tracing::debug!(test = "", "{response:#?}"); |
There was a problem hiding this comment.
nice is using tracing:: this the 'new way' ?
There was a problem hiding this comment.
It's a way. It's the first way I found that enabled me to easily debug tests without seeing all the instrumentation logs. More details in #1201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to further constrain the results without assuming any particular order in the output.