Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CSAF-knowledge out of Graph entirely. #116

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

bobmcwhirter
Copy link
Contributor

Build a CSAF ingestor capable of integrating some CSAF data into the graph. Adjust the CSAF importer/walker to use the ingestor. Ammend the endpoints to support multiple (csaf and osv) advisory inputs for the time being.

Build a CSAF ingestor capable of integrating some CSAF data into the graph.
Adjust the CSAF importer/walker to use the ingestor.
Ammend the endpoints to support multiple (csaf and osv) advisory inputs for the time being.
@bobmcwhirter bobmcwhirter requested a review from jcrossley3 March 26, 2024 19:30
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like the loader

modules/ingestor/src/endpoints/advisory.rs Outdated Show resolved Hide resolved
modules/ingestor/src/service/advisory/csaf/loader.rs Outdated Show resolved Hide resolved
- bring back indent
- simplify the iteration in CSAF loader

Additionally, remove the ContainsNoAdvisory error which
was mis-used for OSV. An advisory can possibly contain
no vulnerability, but that is not an error condition.
@bobmcwhirter bobmcwhirter requested a review from jcrossley3 March 27, 2024 15:30
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe...

modules/ingestor/src/service/advisory/csaf/loader.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bobmcwhirter bobmcwhirter added this pull request to the merge queue Mar 27, 2024
Merged via the queue into trustification:main with commit 2444b87 Mar 27, 2024
1 check passed
@bobmcwhirter bobmcwhirter deleted the move-csaf branch March 27, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants