Skip to content

fix: avoid swallowing sample document cache errors#952

Merged
cybermaggedon merged 1 commit into
trustgraph-ai:release/v2.5from
jmolz:fix-load-sample-doc-cache
May 26, 2026
Merged

fix: avoid swallowing sample document cache errors#952
cybermaggedon merged 1 commit into
trustgraph-ai:release/v2.5from
jmolz:fix-load-sample-doc-cache

Conversation

@jmolz

@jmolz jmolz commented May 26, 2026

Copy link
Copy Markdown
Contributor

Fixes #869.

Summary

  • Replace the bare except around os.mkdir("doc-cache") with os.makedirs(..., exist_ok=True).
  • Remove an unused import and keep request adapter imports at module import scope so the touched file passes Ruff.

Tests

  • python3 -m py_compile trustgraph-cli/trustgraph/cli/load_sample_documents.py
  • ruff check trustgraph-cli/trustgraph/cli/load_sample_documents.py
  • git diff --check

@github-actions

Copy link
Copy Markdown

Contributor License Agreement ✅

All contributors have signed the CLA. Thank you!

@cybermaggedon cybermaggedon self-assigned this May 26, 2026
@cybermaggedon cybermaggedon merged commit f8e8c0e into trustgraph-ai:release/v2.5 May 26, 2026
3 checks passed
@cybermaggedon

Copy link
Copy Markdown
Contributor

Thanks for the fix!

@jmolz

jmolz commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the fix!

My pleasure!

@jmolz jmolz deleted the fix-load-sample-doc-cache branch May 26, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants