Build kubevirt container disk#45
Conversation
Jakob-Naucke
left a comment
Jakob-Naucke
left a comment
There was a problem hiding this comment.
Haven't tested with kubevirt (only did a local build) but LGTM otherwise. You probably want to rebase to eliminate the CI failure.
alicefr
force-pushed
the
create-kv-cd
branch
from
1a8103c to
296883c
Compare
alicefr
force-pushed
the
create-kv-cd
branch
2 times, most recently
from
6ea9e51 to
c6d5068
Compare
|
We need to solve the lack of osbuild in ubuntu. I have tried to run the build in a container but there is some issue with overlayfs inside the container |
alicefr
force-pushed
the
create-kv-cd
branch
11 times, most recently
from
c455565 to
2f835f2
Compare
|
Running cosa takes too many resources for the github actions |
Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
force-pushed
the
create-kv-cd
branch
3 times, most recently
from
7b8db62 to
689da3c
Compare
|
@Jakob-Naucke the CI isn't able to run cosa for kubevirt since it doesn't have enough resource. I think we can integrate the build of kubevirt container disks once we have the beaker machine integrated. However, it is still useful to be able to build container disks. |
alicefr
force-pushed
the
create-kv-cd
branch
2 times, most recently
from
1c44be1 to
d203c45
Compare
Build the container disk out of the fedora coreos with the clevis pin for Trustee support. Signed-off-by: Alice Frosi <afrosi@redhat.com>
|
|
||
| RUN cd /usr/src/ && \ | ||
| git clone https://github.com/trusted-execution-clusters/trustee.git && \ | ||
| git clone https://github.com/confidential-containers/trustee.git && \ |
There was a problem hiding this comment.
Why? Don't we want to use our fork?
There was a problem hiding this comment.
We do, and this diff moves from using our fork to not using our fork
There was a problem hiding this comment.
can we do it in a separate PR? Trustee doesn't have anything to do with building kubevirt disks
Jakob-Naucke
left a comment
Jakob-Naucke
left a comment
There was a problem hiding this comment.
Have tested, so sending approval already, but please still address the above comment
Jakob-Naucke
merged commit 378882c
into
trusted-execution-clusters:main
2 participants
Build the container disk out of the fedora coreos with the clevis pin for Trustee support.
This PR replace the custom-coreos-container-disk with the containerized coreos-assembler. Using
cosaavoids the disablement of selinux. Additionally, osbuild is present and properly works for the conversion of the kubevirt container disks.