fix: disable nonce creation by default #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
force-pushed
the
hotfix/fix_941_1
branch
from
ca1b05a to
3355db1
Compare
|
Would you mind also adding an example for [build]
create_nonce = falseTo the example Trunk.toml here in the repo while at it? |
As the nonce should be unique per request, it doesn't make sense to enable this by default, as that requires additional work on the serving side. On the other side, having a (static) random value isn't correct either. So we keep the current logic, but disable nonce generation by default, making it opt-in. Closes trunk-rs#941
ctron
force-pushed
the
hotfix/fix_941_1
branch
from
3355db1 to
353ae19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the nonce should be unique per request, it doesn't make sense to enable this by default, as that requires additional work on the serving side.
On the other side, having a (static) random value isn't correct either.
So we keep the current logic, but disable nonce generation by default, making it opt-in.
Closes #941