Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add and generate Amharic Translations #633

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Sep 18, 2022

  • Extend generation script
  • Extend Language list
  • Add partial Amharic translation
  • Generate files

* Extend generation script
* Extend Language list
* Add partial Amharic translation
* Generate files
@amenk
Copy link
Contributor Author

amenk commented Sep 18, 2022

@alazar-tekle can you complete the Amharic translation?

Important Only work on the 4 *.arb files in the translation/* sub-folders - do not update the .dart files which are also contained in this branch, they are generated and I can do that.

@amenk amenk changed the title Add an generate Amharic Translations [wip] Add and generate Amharic Translations Sep 18, 2022
@SamuelRioTz
Copy link
Member

@amenk please merge main branch change on you PR, and convert into draf if the PR is not yet ready to merge

@amenk amenk marked this pull request as draft October 2, 2022 08:12
alazar-tekle and others added 7 commits October 2, 2022 14:38
@amenk
Copy link
Contributor Author

amenk commented Oct 3, 2022

@alazar-tekle Thank you, looks technically good -- about page is still missing.

Wondering if the About-Trufi should be extended by an About-Addismap section?

@SamuelRioTz I think this would need local translation overwrites?
Or should we add an "about local additional" block into the core which can be overwritten?

@GustavoTCh
Copy link
Collaborator

@amenk Did you require a custom About-Page, in Trufi-App exist an example about Custom-Pages, but this is a Trufi-Custom-Feedback-Page, for this you require custom-default-values, and you need to use the custom-default-values in main file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants